Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Unicode non-breaking-space into a real space #107

Merged
merged 1 commit into from Jan 18, 2015

Conversation

dcposch
Copy link
Contributor

@dcposch dcposch commented Jan 18, 2015

This fixes things when serving JS with an encoding other than UTF8. Tiny change.

Also thanks for this library, I really like the simple interface and it solves a groty, nasty problem. I downloaded every message from my Gmail, and I'm testing using that. For the most part (ie, on all but some really unusually-encoded email) it seems to work well!

This breaks things when serving JS with an encoding other than UTF8
andris9 added a commit that referenced this pull request Jan 18, 2015
Turn Unicode non-breaking-space into a real space
@andris9 andris9 merged commit c877b26 into nodemailer:master Jan 18, 2015
@andris9
Copy link
Member

andris9 commented Jan 18, 2015

Thanks. The non-breaking spaces are unwanted, I get these because of my keyboard locale – I have to press Alt to get the pipe characters and next if I press the space key before I have released the Alt, I get non-breaking space instead of the regular one.

@dcposch
Copy link
Contributor Author

dcposch commented Jan 18, 2015

Wow, that was quick! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants