New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for legacy Python 2.7 #654
Conversation
Codecov Report
@@ Coverage Diff @@
## master #654 +/- ##
==========================================
- Coverage 71.84% 71.77% -0.07%
==========================================
Files 49 49
Lines 15814 15804 -10
==========================================
- Hits 11361 11343 -18
- Misses 4453 4461 +8
Continue to review full report at Codecov.
|
@@ -1084,12 +1084,12 @@ def _fix_value(self, value): | |||
if not self.__charrange or not self.__replacement: | |||
if sys.maxunicode == 0xFFFF: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if there are narrow 3.x builds? otherwise we can remove this too...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know.
Wow, this looks very nice!
There are also import from future and builtins which could be removed now, as they were primary for the py2/3 compatability. This PR sounds like, that the next version will be 4.0.0 ;) |
@androguard/external-contributors please have a look! |
Most of the changes look simple and good. Changing the formats could cause breakage, so I hope those cases are covered by tests. |
so far, the tests work for mutf8 parsing - which was one of the most annoying things to have both working for py2 and py3. |
Fixes #650.
Adds
python_requires
to help pip.Also upgrade syntax with https://github.com/asottile/pyupgrade and unit tests to use more useful asserts.