Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring struct.unpack and struct.pack usage #693

Merged
merged 8 commits into from May 14, 2019

Conversation

nlachfr
Copy link
Contributor

@nlachfr nlachfr commented May 12, 2019

I've put all the packing / unpacking work in a class DalvikPacker which is initialized in ClassManager during header parsing.

I had to rewrite some functions defined in the top of androguard.core.bytecodes.dvm package in order to access the class manager.

Resolves : #644

@codecov-io
Copy link

codecov-io commented May 12, 2019

Codecov Report

Merging #693 into master will increase coverage by 0.1%.
The diff coverage is 68.1%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #693     +/-   ##
=========================================
+ Coverage    72.6%   72.71%   +0.1%     
=========================================
  Files          50       50             
  Lines       16188    16135     -53     
=========================================
- Hits        11754    11733     -21     
+ Misses       4434     4402     -32
Impacted Files Coverage Δ
tests/parse_dex.py 97.89% <100%> (+0.11%) ⬆️
tests/test_dex.py 98.36% <100%> (+0.11%) ⬆️
androguard/core/bytecodes/dvm.py 63.01% <65.2%> (+0.19%) ⬆️
androguard/core/bytecode.py 43.87% <0%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5104fb...a560d41. Read the comment docs.

@reox reox merged commit 656f530 into androguard:master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace native encoding with little-endian
3 participants