Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix confusing log in session.py #828

Merged
merged 1 commit into from Nov 21, 2020
Merged

Conversation

MissCoconut
Copy link

androguard gives me a confusing log output when I tried to load a session.

{} already exists, overwriting!

Looking around session.py I found the weird log in line 46. , maybe it's better to print a more detailed log.

Signed-off-by: zhangxin08 <zhangxin08@kuaishou.com>
@codecov-io
Copy link

codecov-io commented Nov 14, 2020

Codecov Report

Merging #828 (571ecb8) into master (99e48e7) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
- Coverage   76.83%   76.76%   -0.07%     
==========================================
  Files          51       51              
  Lines       16293    16284       -9     
==========================================
- Hits        12518    12501      -17     
- Misses       3775     3783       +8     
Impacted Files Coverage Δ
androguard/session.py 55.85% <100.00%> (ø)
androguard/core/__init__.py 83.80% <0.00%> (-6.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99e48e7...571ecb8. Read the comment docs.

@reox reox merged commit c064142 into androguard:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants