Fix maxSdkVersion warning in _get_permission_maxsdk method #976
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a potential issue in the
_get_permission_maxsdk
method within the Androguard APK module. The current implementation could lead to aTypeError
whenmaxSdkVersion
isNone
. The proposed fix convertsmaxSdkVersion
to a string in thelogger.warning
call, ensuring that the warning message is correctly logged without causing a TypeError.Changes Made
_get_permission_maxsdk
method to handle the case wheremaxSdkVersion
isNone
.