Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protected access modifier to fields in SyncHttpClient #190

Closed
bkhall opened this issue Mar 13, 2013 · 2 comments
Closed

Add protected access modifier to fields in SyncHttpClient #190

bkhall opened this issue Mar 13, 2013 · 2 comments

Comments

@bkhall
Copy link
Contributor

bkhall commented Mar 13, 2013

I'm working on a project where I need to extend and override some of the methods in the SyncHttpClient class.

The result field and the responseHandler field are not accessible to my child class because the access modifiers are private and default, respectively.

For now, I've modified my local copy of your project to change both to protected so that extending classes can use them.

Please make a simple mod to the SyncHttpClient class:

protected String result;
protected AsyncHttpResponseHandler responseHandler = new AsyncHttpResponseHandler() {
...
}
@loopj
Copy link
Collaborator

loopj commented Mar 13, 2013

Could you make a pull request please

James Smith

On Wednesday, March 13, 2013 at 10:30 AM, Baron Hall wrote:

I'm working on a project where I need to extend and override some of the methods in the SyncHttpClient class.
The result field and the responseHandler field are not accessible to my child class because the access modifiers are private and default, respectively.
For now, I've modified my local copy of your project to change both to protected so that extending classes can use them.
Please make a simple mod to the SyncHttpClient class:
protected String result; protected AsyncHttpResponseHandler responseHandler = new AsyncHttpResponseHandler() { ... }


Reply to this email directly or view it on GitHub (#190).

@bkhall
Copy link
Contributor Author

bkhall commented Mar 13, 2013

Pull request added as #191

Close this one.

@bkhall bkhall closed this as completed Mar 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants