Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No SNI support #224

Closed
viernullvier opened this issue May 6, 2013 · 25 comments
Closed

No SNI support #224

viernullvier opened this issue May 6, 2013 · 25 comments
Assignees
Labels
Milestone

Comments

@viernullvier
Copy link

At the moment AsyncHttpClient does not support SSL connections that use SNI (Server Name Identification). It's a technique that allows servers to return different SSL certificates depending on the requested host name, which allows using SSL in shared hosting scenarios. However, AsyncHttpClient only fetches the default certificate, therefore every request fails - most of the time even without an exception. It would be nice if SNI support could be added to this project.

@phiali
Copy link

phiali commented Aug 28, 2013

I just ran into this issue today and was wondering whether anyone had an idea as to what's involved to implement support for SNI?

@ghost ghost assigned smarek Oct 14, 2013
@smarek
Copy link
Member

smarek commented Oct 14, 2013

Oh, this is interesting, any progress on this @phiali, @viernullvier ?

@phiali
Copy link

phiali commented Oct 14, 2013

Alas I don't think I have the necessary expertise to code this up so as a workaround I had to change the order of my web server config to get the correct host loaded first.

@smarek
Copy link
Member

smarek commented Oct 15, 2013

This is most probably not problem of our library, https://code.google.com/p/android/issues/detail?id=12908
They say they added support in 3.X and later and 2.X won't get any.

@smarek
Copy link
Member

smarek commented Oct 21, 2013

This will be solved by using OkHttp (which is HttpURLConnection instead of DefaultHttpClient / AndroidHttpClient), in 2.0 branch, coming in few weeks.

@phiali
Copy link

phiali commented Oct 21, 2013

That's brilliant news!

@lmribeiro
Copy link

No news about this issue?
When will be released the version 2.0?

@leonardoxh
Copy link

The Code base for 2.0 is here:
https://github.com/leonardoxh/AsyncOkHttpClient

I'm just waiting and implement another features.

@fineswap fineswap reopened this Apr 29, 2014
@gongzunpan
Copy link

印象笔记无法提交笔记,原因如下:

本月帐户上传流量已经达到上限。

原消息详情:
来自:Noor Dawod <notifications@github.com>
发送到:gongzunpan.e099425@m.yinxiang.com
全部收件人:loopj/android-async-http <android-async-http@noreply.github.com>
主题:Re: [android-async-http] No SNI support (#224)

为了防止邮件过多,接下来的360分钟内,你将不会收到报错回复。

升级到印象笔记高级帐户,可以发送的邮件数量将从50封提升到200封。
https://app.yinxiang.com/Checkout.action?origin=email%2Dcommerce

  • 印象笔记团队

@smarek smarek removed the wontfix label Jun 10, 2014
@smarek smarek modified the milestones: 1.5.0, 2.0 Sep 4, 2014
@smarek
Copy link
Member

smarek commented Sep 4, 2014

Moving into 1.5 milestone, as OkHttp integration is not going to happen (there are already libraries using HttpURLConnection), in 1.5 milestone we'll integrate newer version of HttpClient (4.3.3 specifically)

@georgbachmann
Copy link

So SNI support will make it into the 1.5 version? Any estimate on then 1.5 will be ready?
Cause I also have SSL problems in my app that I now figured out are related to SNI...

@alexblack
Copy link

Any update on this? It doesn't look like SNI support is available yet.

@georgbachmann
Copy link

I moved to retrofit and it solved my problems...

@alexblack
Copy link

Retrofit? Sorry I'm not sure what you mean

@georgbachmann
Copy link

@svakulenko
Copy link

Its shame that SNI feature ( supported by java 1.7 which is integrated in Android studio) cant be used & in same moment, its ready to use, de facto.
Im moving to Volley.

@Xoib
Copy link

Xoib commented Mar 6, 2015

I am also leaving this lib because of this particular reason. My 2 cents.

@Zapnologica
Copy link

SNI support would be great. I enjoy this library and moving away from it would be a serious change just to support SNI.

@smarek
Copy link
Member

smarek commented Sep 12, 2015

SNI support is added in 1.4.9, by using upstream HttpClient version 4.3.3, which already supports SNI according to this JIRA ticket https://issues.apache.org/jira/browse/HTTPCLIENT-1119

1.4.9 will be released as soon as possible.

@smarek smarek closed this as completed Sep 12, 2015
@Saren-Arterius
Copy link

I guess sni support is not complete yet? Try GET https://na.cx

@kamilwlf
Copy link

Does SNI work?

@MIkeeJY
Copy link

MIkeeJY commented Mar 30, 2016

already work!!!

@nicpro85
Copy link

nicpro85 commented Apr 2, 2016

not working on the 1.4.9

@AdamMiltonBarker
Copy link

Any news on this ? It is not working on 1.4.9 it is fetching the incorrect certificate

@MIkeeJY
Copy link

MIkeeJY commented Apr 22, 2016

@AdamMiltonBarker maybe you should try okhttp instead of this lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests