Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix behavior on failing Git operations #1084

Merged
merged 1 commit into from Sep 7, 2020
Merged

Fix behavior on failing Git operations #1084

merged 1 commit into from Sep 7, 2020

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Sep 7, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

馃摐 Description

Fixes the swipe refresher state and finish behavior after a Git operation runs into an error.

馃挕 Motivation and Context

We were not correctly finishing/resetting UI state on error.

馃挌 How did you test it?

Lightly, please go over the typical use cases.

馃摑 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

馃敭 Next steps

馃摳 Screenshots / GIFs

@fmeum fmeum mentioned this pull request Sep 7, 2020
Merged
6 tasks
@msfjarvis msfjarvis merged commit 2687763 into develop Sep 7, 2020
@msfjarvis msfjarvis deleted the bug/dont_finish_on_error branch September 7, 2020 08:11
@msfjarvis msfjarvis added this to the 1.12.0 milestone Sep 7, 2020
@msfjarvis msfjarvis added the bug label Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfjarvis msfjarvis msfjarvis approved these changes

@Skrilltrax Skrilltrax Awaiting requested review from Skrilltrax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fmeum @msfjarvis