Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically dismiss decryption screen after 60 seconds #1216

Merged
merged 2 commits into from Nov 22, 2020
Merged

Automatically dismiss decryption screen after 60 seconds #1216

merged 2 commits into from Nov 22, 2020

Conversation

msfjarvis
Copy link
Member

@msfjarvis msfjarvis commented Nov 21, 2020 •
edited

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

馃摐 Description

Dismisses DecryptActivity 60 seconds after successful decryption to prevent a background instance being viewed without any authentication, providing auth bypass.

馃挕 Motivation and Context

Fixes #1215

馃挌 How did you test it?

Verified activity gets finished from both foreground and background

馃摑 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

@msfjarvis
Automatically dismiss decryption screen after 60 seconds
316f69e 
Fixes #1215

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis
Update changelog
871cc22 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis added this to the v2.0.0 milestone Nov 21, 2020
@msfjarvis msfjarvis added C-bug Category: This is a bug P-high Priority: high, must be resolved before next major release labels Nov 21, 2020
fmeum
fmeum approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@fmeum fmeum left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work if the activity enters background?

@msfjarvis
Copy link
Member Author

Does this work if the activity enters background?

Yep, I mentioned that I tested that case in the PR description.

@msfjarvis msfjarvis merged commit a9c73f1 into android-password-store:develop Nov 22, 2020
@msfjarvis msfjarvis deleted the decrypt-timeout branch November 22, 2020 06:17
@fmeum
Copy link
Member

fmeum commented Nov 22, 2020

Does this work if the activity enters background?

Yep, I mentioned that I tested that case in the PR description.

Well, I guess it makes sense: The lifecycleScope is active until the activity is finished, but in that case we don't need the timer anymore. Seems very reliable for this use case.

msfjarvis added a commit that referenced this pull request Dec 21, 2020
@msfjarvis
Automatically dismiss decryption screen after 60 seconds (#1216)
295af9e 
* Automatically dismiss decryption screen after 60 seconds

Fixes #1215

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>

* Update changelog

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
(cherry picked from commit a9c73f1)
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis modified the milestones: v2.0.0, v1.13.2 Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmeum fmeum fmeum approved these changes

@Skrilltrax Skrilltrax Awaiting requested review from Skrilltrax

Assignees
No one assigned
Labels
C-bug Category: This is a bug P-high Priority: high, must be resolved before next major release
Projects
None yet
Milestone
v1.13.2
Development

Successfully merging this pull request may close these issues.

[BUG] password screen is shown after phone unlock
2 participants
@msfjarvis @fmeum