Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a misguided require from GitOperation #826

Merged
merged 1 commit into from Jun 2, 2020
Merged

Remove a misguided require from GitOperation #826

merged 1 commit into from Jun 2, 2020

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jun 2, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

It should have checked for either Password OR SshKey, but is redundant anyway because of the when clause below.

馃挕 Motivation and Context

Fix #825 (comment).

馃挌 How did you test it?

馃摑 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code

馃敭 Next steps

馃摳 Screenshots / GIFs

@fmeum fmeum mentioned this pull request Jun 2, 2020
Merged
6 tasks
@fmeum
Copy link
Member Author

fmeum commented Jun 2, 2020

We could already merge this regardless of #825 such that public keys with passphrases are unblocked.

@msfjarvis msfjarvis merged commit 0c01a5b into master Jun 2, 2020
@msfjarvis msfjarvis deleted the FabianHenneke-patch-1 branch June 2, 2020 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msfjarvis msfjarvis msfjarvis approved these changes

@Skrilltrax Skrilltrax Awaiting requested review from Skrilltrax

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fmeum @msfjarvis @FabianHenneke