Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Autofill result contract bug #941

Merged
merged 1 commit into from Jul 19, 2020

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jul 19, 2020

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

馃摐 Description

Fixes a bug introduced in #910 that breaks Autofill if the OpenKeychain flow requires user interaction.

No changelog entry since Autofill since #910 has not been included in a stable release yet.

馃挕 Motivation and Context

馃挌 How did you test it?

Can use Autofill with my Yubikey again

馃摑 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

馃敭 Next steps

馃摳 Screenshots / GIFs

@fmeum fmeum added this to the 1.10.0 milestone Jul 19, 2020
@fmeum fmeum requested a review from msfjarvis July 19, 2020 15:57
@fmeum fmeum requested a review from Skrilltrax as a code owner July 19, 2020 15:57
@msfjarvis msfjarvis merged commit b9e6385 into develop Jul 19, 2020
@msfjarvis msfjarvis deleted the regression/autofill_result_contract branch July 19, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants