Skip to content

Commit

Permalink
eas_mdls: fix OOB read.
Browse files Browse the repository at this point in the history
Bug: 34031018
Change-Id: I8d373c905f64286b23ec819bdbee51368b12e85a
  • Loading branch information
Wei Jia committed Feb 7, 2017
1 parent 24d7c40 commit 56d1532
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion arm-wt-22k/lib_src/eas_mdls.c
Expand Up @@ -114,6 +114,8 @@
/* this define allows us to use the sndlib.h structures as RW memory */
#define SCNST

#include "log/log.h"

#include "eas_data.h"
#include "eas_host.h"
#include "eas_mdls.h"
Expand Down Expand Up @@ -2084,8 +2086,11 @@ static EAS_RESULT PushcdlStack (EAS_U32 *pStack, EAS_INT *pStackPtr, EAS_U32 val
{

/* stack overflow, return an error */
if (*pStackPtr >= CDL_STACK_SIZE)
if (*pStackPtr >= (CDL_STACK_SIZE - 1)) {
ALOGE("b/34031018, stackPtr(%d)", *pStackPtr);
android_errorWriteLog(0x534e4554, "34031018");
return EAS_ERROR_FILE_FORMAT;
}

/* push the value onto the stack */
*pStackPtr = *pStackPtr + 1;
Expand Down

0 comments on commit 56d1532

Please sign in to comment.