You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Renamed Ambients to match the Ambient -> CompositionLocal rename. Ambients used to be named AmbientFoo, now CompositionLocals are named LocalFoo. (I2d55d)
Thanks for catching this! We need to update the Ambient link to the equivalent CompositionLocal link since that functionality was renamed for the 1.0 launch. It's probably worth us double-checking all the readme links since there have been a lot of updates since most of these samples were first written.
This issue has been automatically marked as stale because it has not had any recent activity. Please comment here if it is still valid so that we can reprioritize it. Thank you for your contributions.
Is there an existing issue for this?
Is there a StackOverflow question about this issue?
Is this an issue related to one of the samples?
Sample app
Jetchat
What happened?
This page:
https://github.com/android/compose-samples/tree/main/Jetchat
links to:
https://developer.android.com/reference/kotlin/androidx/compose/Ambient
which now 404s
Related text:
"
When the Emoji selector is shown, pressing back in the app closes it, intercepting any navigation events. This feature shows a way to integrate Compose and APIs from the Android Framework like OnBackPressedDispatcherOwner via Ambients. The implementation can be found in ConversationUiState.
"
Other links also 404:
https://github.com/android/compose-samples/blob/main/Jetchat/app/src/main/java/com/example/compose/jetchat/conversation/BackHandler.kt
I haven't seen this explicitly stated, but it appears Ambient has been removed/rename something else?
I found this:
https://lcdsmao.dev/jetpack-compose-what-is-the-difference-between-ambient-and-static-ambient/
describing what it was.
This seems related:
https://developer.android.com/jetpack/androidx/releases/compose-runtime
Renamed Ambients to match the Ambient -> CompositionLocal rename. Ambients used to be named AmbientFoo, now CompositionLocals are named LocalFoo. (I2d55d)
I found ambients in old sample code:
https://github.com/android/compose-samples/tree/main/Jetchat
Relevant logcat output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: