[Jetcaster] Add round widget #1406
Open
+293
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamalip
reviewed
May 24, 2024
| <?xml version="1.0" encoding="utf-8"?> | ||
| <appwidget-provider xmlns:android="http://schemas.android.com/apk/res/android" | ||
| android:description="@string/app_widget_description" | ||
| android:minWidth="120dp" |
There was a problem hiding this comment.
In many devices 120dp size doesn't come out to be 2x2 in landscape, and so, even if in portrait it can be more than 120, the widget won't end up at 2x2.
Is the widget able to flex until the min sizes mentioned here for 2x2 - so that in portrait it will land as 2x2 which would look optimal?
https://developer.android.com/design/ui/mobile/guides/widgets/sizing
There was a problem hiding this comment.
I tested and it looks pretty bad at the lower end of the 2x2 bucket. Probably don't want to allow smaller than 120x120
Also... - Add placeholder image for loading and no-album-art states. - Move shared components into AppWidgetComponents.kt Test: Add both widgets to home screen. To test placeholder, clear app data, add widgets to home screen, then toggle day/night mode and see that the placeholder asset changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test: Add both widgets to home screen. To test placeholder, clear app data, add widgets to home screen, then toggle day/night mode and see that the placeholder asset changes.