Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] APP_PLATFORM gets corrupted for API 30+ with LP64 ABIs #1201

Closed
DanAlbert opened this issue Mar 7, 2020 · 0 comments
Closed

[BUG] APP_PLATFORM gets corrupted for API 30+ with LP64 ABIs #1201

DanAlbert opened this issue Mar 7, 2020 · 0 comments
Assignees
@DanAlbert
Labels
bug
Milestone
r21b

Comments

@DanAlbert
Copy link
Member

The code in ndk-build that handles pulling up LP64 API levels to 21 if needed is wrong: https://cs.android.com/android/_/android/platform/ndk/+/5539b2f17d5bdb052bd4580ab900781fb6fcaeba:build/core/setup-abi.mk;l=35;drc=cf5442c13a4cd0fe8b01e27de3850727007988f0

subst acts on any substring, ignoring word boundaries, so 30 is "pulled up" to 210.

r21 will support API 30, so triaging for r21b.
@DanAlbert DanAlbert added the bug label Mar 7, 2020
@DanAlbert DanAlbert added this to the r21b milestone Mar 7, 2020
@DanAlbert DanAlbert self-assigned this Mar 7, 2020
disigma pushed a commit to wimal-build/ndk that referenced this issue Mar 7, 2020
@DanAlbert
Fix API 30+ in ndk-build for LP64 ABIs.
cf1601f 
Test: Targeted API 30, saw compiler get API 30. Targeted API 16, saw
compiler get API 16 for LP32 and 21 for LP64. Once API 30 sysroot is
submitted I can also add a test that builds against API 30.
Bug: android/ndk#1201
Change-Id: I0183d5e803234b25993944df0de9c8c88e7e2004
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
bug
Projects
None yet
Milestone
r21b
Development

No branches or pull requests
1 participant
@DanAlbert