Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] README.md has changed from ordinary file in r20b to directory in r21 and r21b #1229

Closed
gkasten opened this issue Apr 8, 2020 · 1 comment
Closed

[BUG] README.md has changed from ordinary file in r20b to directory in r21 and r21b #1229

gkasten opened this issue Apr 8, 2020 · 1 comment
Assignees
@DanAlbert
Labels
bug
Milestone
r21c

Comments

@gkasten
Copy link
Contributor

gkasten commented Apr 8, 2020

Description

Note: I am filing as bug report rather than documentation, because
even though the problem is in documentation, it is about
the way the documentation is packaged rather than the content.

Problem: in NDK r20b and earlier, README.md was an ordinary file.
In NDK r21 and r21b, README.md is a directory containing a file UserReadme.md .
I think this is probably a regression rather than intentional,
as .md files are usually meant to be Markdown content.
If it was meant to be a directory, I suggest giving it a different suffix (or no suffix).

$ file android-ndk-r20b/README.md android-ndk-r21/README.md android-ndk-r21b-beta2/README.md
android-ndk-r20b/README.md: ASCII text
android-ndk-r21/README.md: directory
android-ndk-r21b-beta2/README.md: directory

$ ls -l android-ndk-r20b/README.md android-ndk-r21/README.md android-ndk-r21b-beta2/README.md
-rw-r--r-- 1 gkasten primarygroup 730 Oct 17 15:34 android-ndk-r20b/README.md

android-ndk-r21b-beta2/README.md:
total 4
-rw-r--r-- 1 gkasten primarygroup 730 Mar 6 22:06 UserReadme.md

android-ndk-r21/README.md:
total 4
-rw-r--r-- 1 gkasten primarygroup 730 Jan 6 12:23 UserReadme.md
$

Environment Details

  • NDK Version: r21 and r21b
  • Build system: not applicable
  • Host OS: Debian Linux
  • ABI: not applicable
  • NDK API level: not applicable
  • Device API level: not applicable
@gkasten gkasten added the bug label Apr 8, 2020
@DanAlbert DanAlbert self-assigned this Apr 8, 2020
@DanAlbert DanAlbert added this to the r21c milestone Apr 8, 2020
@DanAlbert
Copy link
Member

Oops! https://android-review.googlesource.com/c/platform/ndk/+/1282455

grendello added a commit to grendello/xamarin-android that referenced this issue May 29, 2020
@grendello
Bump NDK to r21c
e0904e5 
Context: https://github.com/android/ndk/wiki/Changelog-r21#r21c

Changes:

  * [Issue 1060][0]: A macOS app bundle that is signed and notarized is now
    available for download from our wiki and our website. Note that
    because only bundles may use RPATHs and pass notarization, the
    traditional NDK package for macOS *cannot be notarized. The SDK will
    continue to use the traditional package as the app bundle requires
    layout changes that would make it incompatible with Android Studio.
    The NDK is not quarantined when it is downloaded via the SDK manager,
    so is curently allowed by Gatekeeper. The SDK manager is currently the
    most reliable way to get the NDK for macOS.
  * [Issue 1207][1]: Fix fatal error in clang when building with -O2 on arm64.
  * [Issue 1239][2]: Fix network drive issues for clang.
  * [Issue 1229][3]: README.md turned back to ordinary file.

[0]: android/ndk#1060
[1]: android/ndk#1207
[2]: android/ndk#1239
[3]: android/ndk#1229
@grendello grendello mentioned this issue May 29, 2020
Merged
jonpryor pushed a commit to dotnet/android that referenced this issue Jun 1, 2020
@grendello
Bump to NDK r21c (#4744)
6d26c9a 
Context: https://github.com/android/ndk/wiki/Changelog-r21#r21c

Changes:

  * [Issue 1060][0]: A macOS app bundle that is signed and notarized is
    now available for download from our wiki and our website. Note that
    because only bundles may use RPATHs and pass notarization, the
    traditional NDK package for macOS *cannot* be notarized. The SDK
    will continue to use the traditional package as the app bundle
    requires layout changes that would make it incompatible with
    Android Studio.  The NDK is not quarantined when it is downloaded
    via the SDK manager, so is currently allowed by Gatekeeper. The SDK
    manager is currently the most reliable way to get the NDK for macOS.
  * [Issue 1207][1]: Fix fatal error in clang when building with -O2 on arm64.
  * [Issue 1239][2]: Fix network drive issues for clang.
  * [Issue 1229][3]: README.md turned back to ordinary file.

[0]: android/ndk#1060
[1]: android/ndk#1207
[2]: android/ndk#1239
[3]: android/ndk#1229
jonpryor pushed a commit to dotnet/android that referenced this issue Jun 1, 2020
@grendello @jonpryor
Bump to NDK r21c (#4744)
6df2a2f 
Context: https://github.com/android/ndk/wiki/Changelog-r21#r21c

Changes:

  * [Issue 1060][0]: A macOS app bundle that is signed and notarized is
    now available for download from our wiki and our website. Note that
    because only bundles may use RPATHs and pass notarization, the
    traditional NDK package for macOS *cannot* be notarized. The SDK
    will continue to use the traditional package as the app bundle
    requires layout changes that would make it incompatible with
    Android Studio.  The NDK is not quarantined when it is downloaded
    via the SDK manager, so is currently allowed by Gatekeeper. The SDK
    manager is currently the most reliable way to get the NDK for macOS.
  * [Issue 1207][1]: Fix fatal error in clang when building with -O2 on arm64.
  * [Issue 1239][2]: Fix network drive issues for clang.
  * [Issue 1229][3]: README.md turned back to ordinary file.

[0]: android/ndk#1060
[1]: android/ndk#1207
[2]: android/ndk#1239
[3]: android/ndk#1229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanAlbert DanAlbert

Labels
bug
Projects
None yet
Milestone
r21c
Development

No branches or pull requests
2 participants
@DanAlbert @gkasten