Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Simpleperf callstacks frequently mangled #1840

Open
benjaminRomano opened this issue Feb 6, 2023 · 0 comments
Open

[BUG] Simpleperf callstacks frequently mangled #1840

benjaminRomano opened this issue Feb 6, 2023 · 0 comments
Assignees
Labels

Comments

@benjaminRomano
Copy link

Description

Background

We are exploring differential flame graphs based off of simpleperf data for commit-over-commit performance comparisons. We noticed that frequently our callstacks will be mangled which breaks the ability to do comparisons. Here is an article that discusses this problem in more depth.

I've shared an example of simpleperf in the following ticket (it's in a private component Carmen Jackson can help give access): https://partnerissuetracker.corp.google.com/issues/265123009

Ask
Is there any opportunity to improve heuristic used to patch up callstacks more reliably? Would reducing sampling frequency reduce the odds of callstacks being lost?

I do know that Py was able to patch up some of these mangled callstacks using android-specific heuristics, but it only applies to the main thread: https://github.com/pyricau/simpleperf-cleanup

Affected versions

r23, r24, r25, Canary

Canary version

No response

Host OS

Linux, Mac, Windows

Host OS version

n/a

Affected ABIs

armeabi-v7a, arm64-v8a, x86, x86_64

Build system

Other (specify below)

Other build system

n/a

minSdkVersion

21

Device API level

No response

jbeich pushed a commit to jbeich/platform_system_extras that referenced this issue Feb 7, 2023
At least one person found these docs but not the Studio docs...

Bug: android/ndk#1840
Test: N/A
Change-Id: Ib3b94c6b903762868c91c970b7603bc207ec93f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants