-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Optimized handling of dark/light mode
- Activity handles uiMode config change to prevent re-creating the whole activity - Wrap uiState logic into its classes - Optimize startup to prevent recomposing twice on startup - Optimize startup to call enableEdgeToEdge only once or when change occurs Change-Id: I6f7a48b3b6ce9b55db4ab2ec1770583028e9bc50
- Loading branch information
Showing
4 changed files
with
146 additions
and
94 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
app/src/main/kotlin/com/google/samples/apps/nowinandroid/util/UiExtensions.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* | ||
* Copyright 2024 The Android Open Source Project | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.google.samples.apps.nowinandroid.util | ||
|
||
import android.content.res.Configuration | ||
import androidx.activity.ComponentActivity | ||
import androidx.core.util.Consumer | ||
import kotlinx.coroutines.channels.awaitClose | ||
import kotlinx.coroutines.flow.callbackFlow | ||
import kotlinx.coroutines.flow.conflate | ||
import kotlinx.coroutines.flow.distinctUntilChanged | ||
|
||
/** | ||
* Convenience wrapper for dark mode checking | ||
*/ | ||
val Configuration.isSystemInDarkTheme | ||
get() = (uiMode and Configuration.UI_MODE_NIGHT_MASK) == Configuration.UI_MODE_NIGHT_YES | ||
|
||
/** | ||
* Registers listener for configuration changes to retrieve whether system is in dark theme or not. | ||
* Immediately upon subscribing, it sends the current value and then registers listener for changes. | ||
*/ | ||
fun ComponentActivity.isSystemInDarkTheme() = callbackFlow { | ||
channel.trySend(resources.configuration.isSystemInDarkTheme) | ||
|
||
val listener = Consumer<Configuration> { | ||
channel.trySend(it.isSystemInDarkTheme) | ||
} | ||
|
||
addOnConfigurationChangedListener(listener) | ||
|
||
awaitClose { removeOnConfigurationChangedListener(listener) } | ||
} | ||
.distinctUntilChanged() | ||
.conflate() |