New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightly builds with baseline profiles #1173
base: main
Are you sure you want to change the base?
Conversation
dcb23c1
to
81956f4
Compare
RFR. @JoseAlcerreca & @dturner PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm generally ok with this, but it would be nice if Don/Jose took a look as they maintain the project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started the review assuming this nightly was only for BP generation and only realized you were creating a full nightly. I think the main
build should be our SOT for status, so just make this one about BP.
Combined test coverage report
|
Combined test coverage report
|
f770711
to
c35b1e4
Compare
Combined test coverage report
|
@JoseAlcerreca could this be a flaky test?
If so, could you show me how to fix it or approve the PR so it can be merged? |
Let's merge #1395 first and make sure this one passes |
SGTM |
Change-Id: I0c59e12f2860d67d855801f892f8f00d0edc64a7
Change-Id: I07df3c3cf72fcf6cff463bc163af4c74d61d1c95
Change-Id: Id9899cae3aaa6b2a4d37c41c1725b03b4dcf9779
Change-Id: Icb9d40d64378b4d0d66ab5edf958064cbc778fc0
Change-Id: I3255f044dbd8a3a79f886871a1850b5f88bbd9a1
c35b1e4
to
aca83e4
Compare
Combined test coverage report
|
Change-Id: Ic52530ebd41921c275e92cef139578f3d8957dae
Combined test coverage report
|
Change-Id: I045c75e84aa42ebb591c8a09c0370de0e81c7826
Combined test coverage report
|
Change-Id: I63fe1a5fe457cbe420e37e08716f4e28c167a273
Combined test coverage report
|
Change-Id: Id227cf9009a094e950f9dc97dccfb0f4c9a8fae6
Combined test coverage report
|
Change-Id: I162cd9eca724c30d839add912359482cbce7c68e
Thanks for submitting a pull request. Please include the following information.
What I have done and why
Enabled baseline profile generation for new nightly build type.
With KVM, GMD run smoothly and BP generation is not negatively affected any longer.
Enabling nightly builds for this keeps PR builds fast while allowing for baseline profiles to be generated regularly as well.
Fixes #<issue_number_goes_here>
Do tests pass?
DemoDebug
variant:./gradlew testDemoDebug
./gradlew --init-script gradle/init.gradle.kts spotlessApply