Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type-safe navigation #1413

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Add type-safe navigation #1413

wants to merge 30 commits into from
+153 −146

Commits on May 1, 2024

  1. Use SafeArgs navigation for Topic feature 

    Change-Id: Idf4386f10c780d3edc1f8aa11b428cb146e982c3
    @dturner
    dturner committed May 1, 2024
    Configuration menu
    Copy the full SHA
    6dc59e7 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Migrate Interests nested NavHost to safe args 

    Change-Id: I4f3c310be693ecbcbc8b99c4e573d7fc6e9a2f74
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    d96bcf8 View commit details
    Browse the repository at this point in the history

  2. Update to alpha08, use toRoute to obtain destination inside VM 

    Change-Id: I72f617c594b5e0ae272cf94d2d7288446153420a
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    4909972 View commit details
    Browse the repository at this point in the history

  3. Migrate remainder of app to type-safe navigation 

    Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    89163b5 View commit details
    Browse the repository at this point in the history

  4. Remove Interests2PaneViewModel as it was overkill for holding a singl… 

    …e string value

Change-Id: I4767578028b55c2bc7b1763bdeef87345b9fbf06
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    9779074 View commit details
    Browse the repository at this point in the history

  5. Add deeplink action to enable testing from terminal 

    Change-Id: Ia112f87c7f1bb7fa9ebe08b82d26e00b4ad17d05
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    29e08ea View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into dt/nav-safe-args

    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2d45b84 View commit details
    Browse the repository at this point in the history

  7. Fix spotless 

    Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    924391c View commit details
    Browse the repository at this point in the history

  8. 🤖 Updates baselines for Dependency Guard

    @dturner @github-actions
    dturner authored and github-actions[bot] committed May 3, 2024
    Configuration menu
    Copy the full SHA
    0f926ba View commit details
    Browse the repository at this point in the history

  9. 🤖 Updates screenshots

    @dturner @github-actions
    dturner authored and github-actions[bot] committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8cc0fc0 View commit details
    Browse the repository at this point in the history

  10. Change startDestination from KClass to default instance 

    Change-Id: Ia5bb0abd366653aff5cf5a772ac11a837e96b9b1
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    116e961 View commit details
    Browse the repository at this point in the history

  11. Use navigation argument topicId as default value to InterestListDetai… 

    …lScreen

Change-Id: I659f729191bce00683b1621c360c8f36f00595f9
    @dturner
    dturner committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2264451 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fix issue where selected topic in list was not showing as selected. M… 

    …inor tidy ups.

Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
    @dturner
    dturner committed May 7, 2024
    Configuration menu
    Copy the full SHA
    7ec21d9 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Update ForYou destination to match current deeplink pattern 

    Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
    @dturner
    dturner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    f67f4d1 View commit details
    Browse the repository at this point in the history

  2. Use version catalog reference to serialization plugin 

    Change-Id: Ia197b2403e8250720387123d8c5d5d9ad809a036
    @dturner
    dturner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    93a48a2 View commit details
    Browse the repository at this point in the history

  3. Remove autoVerify from intent filter 

    Change-Id: Ia7460a618b2ddf8a25debce92308573bc18368a8
    @dturner
    dturner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    173ac67 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary comment 

    Change-Id: I535ca7fcec48c32b727c1c6c465a719d60dcb0f9
    @dturner
    dturner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    3cff2fb View commit details
    Browse the repository at this point in the history

  5. Add specific type for deeplinks 

    Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75
    @dturner
    dturner committed May 8, 2024
    Configuration menu
    Copy the full SHA
    4a84cf2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Merge branch 'main' into dt/nav-safe-args (AnimatedPane broken) 

    * main:
  Save nested nav key in instance state
  🤖 Updates baselines for Dependency Guard
  Recreate nested nav to work with AnimatedPane
  Remove forgotten Trace.endSection()
  Offload connectivity monitor to a background thread

Change-Id: I4002a07484a4d633c57406aedabf9f5d813a8592
    @dturner
    dturner committed May 9, 2024
    Configuration menu
    Copy the full SHA
    f711e69 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Update to adaptive alpha12, fix merge issues 

    Change-Id: I99703db37712abb46b844beb73bb14ddd5283165
    @dturner
    dturner committed May 14, 2024
    Configuration menu
    Copy the full SHA
    68152e5 View commit details
    Browse the repository at this point in the history

  2. Remove different deeplink destination, add route for nested nav host 

    Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad
    @dturner
    dturner committed May 14, 2024
    Configuration menu
    Copy the full SHA
    aba2b2c View commit details
    Browse the repository at this point in the history

  3. Fix tests, fix spotless 

    Change-Id: I55e779abe4ee49dc93916d9e1184ed81e1b2bbd0
    @dturner
    dturner committed May 14, 2024
    Configuration menu
    Copy the full SHA
    be752e7 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Update to navigation 2.8.0-beta01 

    Change-Id: I2f01dc19e37b9fe890ad861909f57198cc5262d4
    @dturner
    dturner committed May 16, 2024
    Configuration menu
    Copy the full SHA
    8fc2e15 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Merge branch 'main' into dt/nav-safe-args 

    * main:
  Remove the printModulePaths task and read modules direct from settings
  Update pull_request_template.md
  Made pull request instructions clearer
  Update gradle wrapper
  Upgrade AGP to 8.4.0, Android Build Tools to 31.4.0, and Gradle to 8.7.
  Regenerate SVG graphs and cleanup/reformat files
  Update build.gradle.kts
  Remove duplicated AndroidX Work testing dependency
  Bump gradle/wrapper-validation-action from 2 to 3
  🤖 Updates baselines for Dependency Guard
  Bump com.dropbox.dependency-guard from 0.4.3 to 0.5.0
  Bump protobuf from 3.25.2 to 4.26.0
  Bump app.cash.turbine:turbine from 1.0.0 to 1.1.0
  Bump androidxMacroBenchmark from 1.2.2 to 1.2.3
  🤖 Updates baselines for Dependency Guard
  Unnecessary safe call on a non-null receiver
  Bump androidx.activity:activity-compose from 1.8.0 to 1.8.2
  Apply suggestions from code review
  Move Android instrumented test `ThemeTest` to unit test

Change-Id: Id3283279ca5a9d90c2bbc4740d6c583ba8dded41
    @dturner
    dturner committed May 30, 2024
    Configuration menu
    Copy the full SHA
    041e46e View commit details
    Browse the repository at this point in the history

  2. Rename Destinations to Routes 

    Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
    @dturner
    dturner committed May 30, 2024
    Configuration menu
    Copy the full SHA
    da8f32a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into dt/nav-safe-args 

    * main:
  Kotlin 2.0.0 (#1036)
  Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
  🤖 Updates screenshots
  🤖 Updates baselines for Dependency Guard
  Update material3-adaptive to beta01
  🤖 Updates baselines for Dependency Guard
  Bump androidxComposeAlpha from 1.7.0-alpha08 to 1.7.0-beta01
  🤖 Updates baselines for Dependency Guard
  Bump hilt from 2.51 to 2.51.1
  Add NavigationSuiteScaffold
  Fix state loss with workaround

Change-Id: I14d7294fe93f68b9aca6df9bf7bf87ff95583581
    @dturner
    dturner committed May 30, 2024
    Configuration menu
    Copy the full SHA
    a6397b7 View commit details
    Browse the repository at this point in the history

  4. 🤖 Updates baselines for Dependency Guard

    @dturner @github-actions
    dturner authored and github-actions[bot] committed May 30, 2024
    Configuration menu
    Copy the full SHA
    b73ee6d View commit details
    Browse the repository at this point in the history

  5. Rename ForYouRoute composable to ForYouScreen 

    Change-Id: I47456f19f2b41cafe44ba7636cad6d1fea782a33
    @dturner
    dturner committed May 30, 2024
    Configuration menu
    Copy the full SHA
    95bdc0f View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Add Robolectric to allow ViewModel tests to pass 

    Change-Id: I782fab167103edbdaa1d95839b4fbc6e659fef4e
    @dturner
    dturner committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    ec71b2a View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Remove string-based argument name from navigation code 

    Change-Id: I7c880cc73374e053ea0d41df00a4bda95ed4b551
    @dturner
    dturner committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    fc58680 View commit details
    Browse the repository at this point in the history