Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix state loss with workaround #1419

Merged
merged 2 commits into from
May 29, 2024
Merged

Fix state loss with workaround #1419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a324fcc
Fix state loss with workaround
alexvanyo May 6, 2024
488b97a
Update app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/Ni…
dturner May 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 8 additions & 7 deletions app/src/main/kotlin/com/google/samples/apps/nowinandroid/ui/NiaApp.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,13 +201,14 @@ internal fun NiaApp(
}

Box(
modifier = if (shouldShowTopAppBar) {
Modifier.consumeWindowInsets(
WindowInsets.safeDrawing.only(WindowInsetsSides.Top),
)
} else {
Modifier
},
// Workaround for https://issuetracker.google.com/338478720
modifier = Modifier.consumeWindowInsets(
dturner marked this conversation as resolved.
Show resolved Hide resolved
if (shouldShowTopAppBar) {
WindowInsets.safeDrawing.only(WindowInsetsSides.Top)
} else {
WindowInsets(0, 0, 0, 0)
},
),
) {
NiaNavHost(
appState = appState,
Expand Down