Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with module graphs not generating on Linux #1486

Closed
wants to merge 3 commits into from

Conversation

neil3000
Copy link

What I have done and why

In commit e5008c6 a condition was added to check if the grep command supports the -P parameter.

However, from my testing at least, this doesn't seem to work as it uses /dev/null to check for "", probably based on the assumption that grep will return positively even if it doesn't find the matching string (here ""), which isn't true when using /dev/null.

At least that is my understanding of the issue, feel free to correct me if it isn't exactly that <3
What is sure however is that it doesn't work on my setup, even though I do have the grep -P option and it works fine (worked fine before e5008c6, and still works when removing the condition).

Instead of doing a grep -P "" /dev/null I changed it to a echo "" | grep -P "", the result will still be positive as grep doesn't return an error when no matches are found, but the string isn't ""null"" as with /dev/null, and so the condition doesn't always return false.

@dturner
Copy link
Collaborator

dturner commented Jul 2, 2024

Should be fixed with #1506. Please file an issue if not.

@dturner dturner closed this Jul 2, 2024
@SimonMarquis
Copy link
Contributor

#1506 did not change this grep command, and is still used here

# Get the module paths
module_paths=$(${GREP_COMMAND} -oP 'include\("\K[^"]+' settings.gradle.kts)

This should probably be restored and merged.
(not sure why the order of the error message has been changed though 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants