Fixed issue with module graphs not generating on Linux #1486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
In commit e5008c6 a condition was added to check if the grep command supports the -P parameter.
However, from my testing at least, this doesn't seem to work as it uses /dev/null to check for "", probably based on the assumption that grep will return positively even if it doesn't find the matching string (here ""), which isn't true when using /dev/null.
At least that is my understanding of the issue, feel free to correct me if it isn't exactly that <3
What is sure however is that it doesn't work on my setup, even though I do have the grep -P option and it works fine (worked fine before e5008c6, and still works when removing the condition).
Instead of doing a
grep -P "" /dev/null
I changed it to aecho "" | grep -P ""
, the result will still be positive as grep doesn't return an error when no matches are found, but the string isn't ""null"" as with /dev/null, and so the condition doesn't always return false.