Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use @Upsert from Room instead of a custom helper #311

Merged
merged 3 commits into from Oct 10, 2022
Merged

Use @Upsert from Room instead of a custom helper #311

merged 3 commits into from Oct 10, 2022

Conversation

yveskalume
Copy link
Contributor

Fix #243

@yveskalume
update : Use @upsert from Room instead of a custom helper
d094e96 
Change-Id: I21194fda29976e069d5cfc1e083cf48d3dd149fe
@alexvanyo alexvanyo requested a review from tunjid October 3, 2022 08:24
alexvanyo
alexvanyo reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! One request to remove the code that will be unused as part of this, and also to fix up the tests that are failing.

core/database/src/main/java/com/google/samples/apps/nowinandroid/core/database/dao/AuthorDao.kt Show resolved Hide resolved
alexvanyo
alexvanyo reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! One request to remove the code that will be unused as part of this, and also to fix up the tests that are failing.

@yveskalume
update : remove unused upsert method.
4006d8d 
Change-Id: I737c7c0078512594a719fe3966cdd99ead39331f
@yveskalume
fix failling tests
b05ea47 
Change-Id: I88b6d80dfb473010f8742890d9f6b17ed153ecc5
tunjid
tunjid approved these changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@tunjid tunjid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It looks great! Just waiting on CI to pass.

@tunjid tunjid merged commit 8dbd53c into android:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvanyo alexvanyo alexvanyo left review comments

@tunjid tunjid tunjid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Use @Upsert from Room
3 participants
@yveskalume @alexvanyo @tunjid