Fix app package name clash with benchmark module #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtek-kalicinski
force-pushed
the
wk/agp8-changes
branch
from
2689d4f
to
8eba48c
Compare
dturner
approved these changes
Nov 11, 2022
|
@wojtek-kalicinski ping :D |
wojtek-kalicinski
force-pushed
the
wk/agp8-changes
branch
2 times, most recently
from
42fa4ac
to
de02216
Compare
Change-Id: I5889ef4b9338a940f43efc7629dca155068588ec
wojtek-kalicinski
force-pushed
the
wk/agp8-changes
branch
from
de02216
to
7afc356
Compare
SimonMarquis
added a commit
to SimonMarquis/nowinandroid
that referenced
this pull request
Feb 4, 2023
``` package="com.google.samples.apps.nowinandroid.uitesthiltmanifest" found in source AndroidManifest.xml. Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated. Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information. ``` For reference, this work was started in all these PRs: - android#32 - android#333 - android#368 - android#460 This should be the last time we have to do this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A combination of build type app id suffix (".benchmark") and the "benchmark" module created a situation in which the main APK had same package name as the test APK, resulting in errors. Changing the name and namespace of the benchmark module to "benchmarks" fixes it.