Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace gradle script with explicit convention plugins #38

Merged
merged 7 commits into from May 31, 2022
Merged

Replace gradle script with explicit convention plugins #38

merged 7 commits into from May 31, 2022

Conversation

sjcqs
Copy link
Contributor

@sjcqs sjcqs commented May 15, 2022 •
edited

name: Replace Gradle script with explicit convention plugins
about:
label: 'triage me'

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #39 馃

@google-cla
Copy link

google-cla bot commented May 15, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@sjcqs sjcqs mentioned this pull request May 15, 2022
Closed
@sjcqs sjcqs force-pushed the scjqs/improve-configuration-time branch from 38d233f to b177174 Compare May 15, 2022 09:43
@dturner dturner requested a review from alexvanyo May 16, 2022 13:52
alexvanyo
alexvanyo requested changes May 16, 2022
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great! And it definitely sets up the build faster locally for me as well.

Just a couple minor comments, and I want to double check the apply versus withPlugin behavior.

build-logic/convention/src/main/kotlin/AndroidApplicationComposeConventionPlugin.kt Show resolved Hide resolved
build-logic/convention/src/main/kotlin/AndroidApplicationComposeConventionPlugin.kt Outdated Show resolved Hide resolved
build-logic/convention/src/main/kotlin/SpotlessConventionPlugin.kt Outdated Show resolved Hide resolved
@sjcqs sjcqs force-pushed the scjqs/improve-configuration-time branch 2 times, most recently from 2c91f70 to 91c43f4 Compare May 17, 2022 08:35
@alexvanyo alexvanyo self-requested a review May 23, 2022 20:17
@sjcqs
Copy link
Contributor Author

sjcqs commented May 24, 2022

@alexvanyo do you want me to fix the conflicts? 馃槃

@alexvanyo
Copy link
Contributor

Ah sorry, we made an internal change that conflicts now. If you want to rebase that would be great, otherwise I can!

sjcqs and others added 6 commits May 24, 2022 12:13
@sjcqs
Replace gradle script with explicit convention plugins
555c4b4
@sjcqs
Update build-logic README.md
39a97cc
@sjcqs
Make build-logic extension internal
35e6a5f 
Those extensions *will* be accessible in build.gradle.kts if not made internal.
They are used to configure the conventions plugins internally.
They should not be accessible by the consumer Gradle modules.
@alexvanyo @sjcqs
Remove extra space
b747531 
Co-authored-by: Alex Vanyo <vanyoalex@gmail.com>
@sjcqs
Add copyrights
bb67215
@sjcqs
Apply used plugins in conventions
8878265
@sjcqs sjcqs force-pushed the scjqs/improve-configuration-time branch from 91c43f4 to 8878265 Compare May 24, 2022 10:18
@sud007
Copy link
Contributor

sud007 commented May 24, 2022 •
edited

This was really cool stuff. how much impact does this make really on gradle sync time?

@sjcqs
Copy link
Contributor Author

sjcqs commented May 25, 2022

This was really cool stuff. how much impact does this make really on gradle sync time?

I did some basic profiling in the issue 馃槃 : #39

The configuration part went from 12.724s to 0.765s

alexvanyo
alexvanyo approved these changes May 27, 2022
View reviewed changes
Copy link
Contributor

@alexvanyo alexvanyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of the rebase! It all looks good except for just one change that'd I'd like to do separately, outside of the conversion PR.

One that's changed, I'll merge!

build-logic/convention/src/main/kotlin/AndroidTestConventionPlugin.kt Outdated Show resolved Hide resolved
@sjcqs sjcqs force-pushed the scjqs/improve-configuration-time branch from ec91f97 to 7c761c5 Compare May 29, 2022 18:02
@alexvanyo alexvanyo merged commit d20e7a3 into android:main May 31, 2022
@alexvanyo
Copy link
Contributor

Merged, thank you @sjcqs !

@alexvanyo alexvanyo mentioned this pull request May 31, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvanyo alexvanyo alexvanyo approved these changes

Assignees

@alexvanyo alexvanyo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Build logic] Relying on Gradle script to generate plugins is slowing out the build
3 participants
@sjcqs @alexvanyo @sud007