Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement recent searches #670

Closed
wants to merge 15 commits into from
Closed

Implement recent searches #670

wants to merge 15 commits into from

Conversation

thagikura
Copy link
Contributor 

- Add Repository and Dao for recent searches
- Add recent searches body in the Search UI
- Add relevant tests

Screenshots:

thagikura and others added 14 commits April 11, 2023 23:59
@thagikura
Add UI skeleton for the search feature
86fe3b2 
This CL adds an UI skeleton of the search feature including:
- The search navigation icon in the NiaTopAppBar
- The text field to enter the search query
- Almost empty ViewModel

Bug: 216019540
Change-Id: Ic2355a7634e5c5c60f72276741175d9e637db5eb
@thagikura
Fix copyright header
5e28769 
Change-Id: I70a0732f67617a96b6dd20eccbc6c02a9dafdabd
@thagikura
Fix formatting issues
2eddf0b 
Change-Id: Id9efb259bd8ac6a83af19fb370869aa19f78831d
@thagikura
Implement SearchScreen
13e6cc4 
- Empty search screen if the search result is empty
- Topics contents that reuses the TopicsTabContent for InterestsScreen
- Updates contents that reuses the newsFeed for ForYouScreen

TODO: Needs to add RecentSearch
Change-Id: I19179336a60b5165e8b59508fb03dd8f55a16f96
@thagikura
Fix format issues
83b640a 
Change-Id: I5b87f89d824961cb9aec039281e784d6dec0716b
@thagikura
Wire the SearchScreen and the backend of search related data
6f9d2fe 
Change-Id: I103c903c936137c41d7d11be0731438d9ee557d9
@thagikura
Fix format issues
477838f
@thagikura
Change the result type of searchAll* in *FtsDao as Flow to not block the
333a248 
calling thread
@thagikura
Add suspend to getOneOff* read queries
0c6e542
@thagikura
Add a handler a topic is clicked in the search screen
696cc1a
@thagikura
Add missing suspend
179b3d4
@thagikura
Fix the argument name
cd03bd1
@thagikura
Address review feedback
37d4b65 
Change-Id: If336af8fa5c58d6401dfd7a561a1a340ff388175
@thagikura
Fix format issues
55483e8 
Change-Id: I94aefab87ff9e05819800c516a0f2979f5f89d76
@thagikura
Copy link
Contributor Author

#668 should be merged first because this PR is created on top of it.

@thagikura thagikura mentioned this pull request Apr 18, 2023
Merged
hoangchungk53qx1
hoangchungk53qx1 reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@hoangchungk53qx1 hoangchungk53qx1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use .catch in flow

@thagikura
Copy link
Contributor Author

you can use .catch in flow

Addressed. Thanks.

@thagikura
Copy link
Contributor Author

thagikura commented Apr 18, 2023 •
edited
Loading

Note to reviewers,
@dturner @neelanshsahai
#668 needs to be reviewed first because this PR is created on top of it.

@thagikura
Implement recent searches
63cd890 
- Add Repository and Dao for recent searches
- Add recent searches body in the Search UI
- Add relevant tests
@thagikura thagikura mentioned this pull request Apr 20, 2023
Merged
@thagikura
Copy link
Contributor Author

Closing this in favor of #675 since I had to resolve a lot of conflicts with this PR.

@thagikura thagikura closed this Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangchungk53qx1 hoangchungk53qx1 hoangchungk53qx1 left review comments

@dturner dturner Awaiting requested review from dturner

@neelanshsahai neelanshsahai Awaiting requested review from neelanshsahai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thagikura @hoangchungk53qx1