Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create externalDependencies.xml #783

Closed
wants to merge 1 commit into from

Conversation

SimonMarquis
Copy link
Contributor

This will ensure IntelliJ IDEA will prompt the user to install these plugins when contributing to the project.
https://www.jetbrains.com/help/idea/managing-plugins.html#required-plugins

This will ensure IntelliJ IDEA will prompt the user to install these plugins when contributing to the project.
https://www.jetbrains.com/help/idea/managing-plugins.html#required-plugins
@dturner
Copy link
Collaborator

dturner commented Jun 14, 2023

I'm not in favour of adding this as it implies that we support IntelliJ IDEA for development. Obviously external contributors are welcome to use whatever IDE they like to contribute as long as the code conforms to our guidelines, but Android Studio is the only officially supported IDE.

I will leave open and raise with the team though to see if there are other opinions.

@dturner dturner added the discuss needs further discussion or investigation label Jun 14, 2023
@SimonMarquis
Copy link
Contributor Author

When I said IntelliJ IDEA, I also meant Android Studio. Both share the same settings.
externalDependencies.xml is developped on the IntelliJ IDE but is compatible with all IDE based on it.

@dturner
Copy link
Collaborator

dturner commented Jun 21, 2023

Chatted with @alexvanyo about this and we agreed that this isn't something that we want to merge. Mostly because:

  • it'll probably be needlessly copied by other developers
  • it's another thing we'll have to maintain

Thanks for the idea though.

@dturner dturner closed this Jun 21, 2023
@SimonMarquis SimonMarquis deleted the patch-7 branch September 16, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss needs further discussion or investigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants