New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add automated baseline profile generation #880

Merged

keyboardsurfer merged 25 commits into main from bw/automateBaselineProfileGeneration

Nov 15, 2023

Member

keyboardsurfer commented Aug 4, 2023 •

edited

Baseline profile generation is disabled for the PR level Build task.
Release tasks require a fresh baseline profile. A new profile is generated using the baseline profile Gradle plugin.

Prepares for usage of dex layout optimizations which can be actively used once NiA switches to AGP 8.2+.

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch 4 times, most recently from ec42fac to a46f315 Compare

August 8, 2023 16:26

Contributor

alexvanyo commented Aug 11, 2023

The build is currently failing during the Build all build type and flavor permutations step declared here:

nowinandroid/.github/workflows/Build.yaml

Lines 43 to 44 in 492697c

    
           - name: Build all build type and flavor permutations 
        
             run: ./gradlew assemble

Since it's part of the initial build, that is running on ubuntu-latest right now (which won't work with emulators), and also doesn't have the GMD flags we normally pass to GMD tasks in androidTest-GMD.

SimonMarquis mentioned this pull request

Migrate to baseline profile plugin #869

Draft

SimonMarquis reviewed

View reviewed changes

benchmarks/src/main/java/com/google/samples/apps/nowinandroid/interests/InterestsActions.kt Outdated Show resolved Hide resolved

SimonMarquis reviewed

View reviewed changes

app/build.gradle.kts Show resolved Hide resolved

SimonMarquis reviewed

View reviewed changes

benchmarks/build.gradle.kts Outdated Show resolved Hide resolved

SimonMarquis reviewed

View reviewed changes

benchmarks/src/main/java/com/google/samples/apps/nowinandroid/foryou/ForYouActions.kt Outdated Show resolved Hide resolved

SimonMarquis reviewed

View reviewed changes

gradle/libs.versions.toml Outdated Show resolved Hide resolved

SimonMarquis reviewed

View reviewed changes

gradle/libs.versions.toml Outdated Show resolved Hide resolved

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch from 9e60d34 to 0f459c9 Compare

August 25, 2023 12:11

Contributor

SimonMarquis commented Aug 27, 2023

FYI: version 1.2.0-beta04 already takes care of generating the corresponding Run Configurations :)

And the Baseline Profiles module wizard has been updated in Android Studio Iguana | 2023.2.1.

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch 10 times, most recently from 21c1abc to 61f579c Compare

August 31, 2023 08:29

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch 2 times, most recently from 4bc53fb to 5435a80 Compare

October 10, 2023 11:28

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch 2 times, most recently from 8c73cb6 to 043b6b9 Compare

November 13, 2023 12:13

JoseAlcerreca reviewed

View reviewed changes

benchmarks/build.gradle.kts Show resolved Hide resolved

JoseAlcerreca reviewed

View reviewed changes

gradle/libs.versions.toml Outdated Show resolved Hide resolved

keyboardsurfer added 13 commits

November 13, 2023 21:55


          Stable release and recent GMD device

75acb18

Change-Id: Id9719e352b16385d721cb3e377c8547bb018d7fb


          Reduce flakiness by adding wait to benchmark

e37cacd

Change-Id: Ibcc8897bf019070059eee5f99faf0cea384b9fc4


          More convenient waiting for objects

ec52a75

Change-Id: I21c4f78bd963c4ed7c6d937cc60b3cf6c5c42b89


          Rename junit dependency to androidx-junit

0b89d7f

Change-Id: I913fcc10dff796fefb6ec75bc054dd7b78df7691


          Only run baseline profile benchmarks during GH workflow

51bd15a

Change-Id: I3180f6e132068c4669bfd848906dfd4a7a68c6c0


          Enable automatic BP generation for only release builds

d326b3a

Change-Id: I570e476eeaf2aaa1f6b5533061541e2adb3ca82c


          Update GitHub workflows for BP generation

dd6cfa8

* Fix baseline profile generation for release workflow
* Remove some limitations from general build

Change-Id: I28ed8ee43eaa4240eaefafcc79e2718d609edf41


          Disable BP generation from Build workflow

5fe3826

Change-Id: I56f9686709d10bd3fd98c58e33c7b6c36c1aa9e1


          Re-introduce GMD limitations due to failing build on GHA

8a2aab2

Change-Id: Icacbb72deaa426acbeb1cd6db9e94a7a66a72786


          Specify modules and skip benchmarking Build workflow

51360f9

Change-Id: I2ea78898ef98592aec789f6bf8fe18b72a7d0334


          Enable GMD for release build baseline profile generation

Change-Id: Id9c97d51e8f68e7ba5b898ea41bd853a26ffcfa9


          Disable BP generation for non-release builds

b3c0218

Change-Id: I633e156e8f8fc2d172bbbb82ed05ced2d5ba1615


          Address review feedback

Change-Id: I5d349ebb0e667cbdf2e1acc1a0df30d6b252b132

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch from f7ec256 to 1029289 Compare

November 13, 2023 20:56

keyboardsurfer changed the title ~~WIP: Adding automated baseline profile generation~~ Add automated baseline profile generation


          Cleanup

d93fe88

Change-Id: I5dc178dc2fcacc446b426cf19af8f2f8e388299b

keyboardsurfer force-pushed the bw/automateBaselineProfileGeneration branch from f207a59 to d93fe88 Compare

November 14, 2023 09:11

keyboardsurfer requested review from JoseAlcerreca and dturner

November 14, 2023 09:13

keyboardsurfer marked this pull request as ready for review

November 14, 2023 09:13

JoseAlcerreca reviewed

View reviewed changes

...c/main/kotlin/com/google/samples/apps/nowinandroid/baselineprofile/StartupBaselineProfile.kt Outdated Show resolved Hide resolved

JoseAlcerreca reviewed

View reviewed changes

benchmarks/src/main/kotlin/com/google/samples/apps/nowinandroid/startup/StartupBenchmark.kt Outdated Show resolved Hide resolved

Contributor

JoseAlcerreca commented Nov 14, 2023

I suggest moving profile generation to its own module. Apart from that this LGTM!


          Update benchmarks/src/main/kotlin/com/google/samples/apps/nowinandroi…

2c1bb11

…d/baselineprofile/StartupBaselineProfile.kt

Co-authored-by: Jose Alcérreca <JoseAlcerreca@users.noreply.github.com>

keyboardsurfer mentioned this pull request

Fix GitHub build for macrobenchmark sample android/performance-samples#260

Open


          Add comment to iterations.

0db46d7

Change-Id: I7288663d111bcc0b06261fdc0fe833271f7f5228

JoseAlcerreca approved these changes

View reviewed changes


          Sort last plugin alphabetically

83536d3

Change-Id: I255fbd448d602055c3f395843d7753c7e7d85c86

keyboardsurfer merged commit aa8ce0e into main

4 checks passed

keyboardsurfer deleted the bw/automateBaselineProfileGeneration branch

November 15, 2023 12:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment