Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] [Camera2] - Implementation of "UltraHDR Image Capture" #56

Merged
merged 8 commits into from Jul 11, 2023

Conversation

madebymozart
Copy link
Contributor

@madebymozart madebymozart commented Jul 11, 2023

Description

This CL contains sample code for Capturing an UltraHDR Image using Camera2 on API 34 and above. Made some cosmetic changes to the current Camera2 Samples to better represent them in the list of samples

How Has This Been Tested?

Test Configuration - Android Emulator - API 34

Important Notes

At the time for writing, there are no real hardware devices that are capable of taking an UltraHDR image via the Camera2 API, so this CLs was tested with the Emulated Cameras using the Android Emulator for functionality.

Currently when running this Sample, If the device does not support UltraHDR capture, This screen will show:

To run this sample on an emulator and get passed this "UltraHDR Capture is not supported" message, you must configure an emulator with API 34 & assure both the front & back emulator cameras are set to "Emulated" Like below:
Screenshot 2023-07-10 at 11 16 39 PM

Visualizing The Captured UltraHDR Image

The VisualizingAnUltraHDRGainmap Sample (merged here: #53) has been updated to receive the captured Image from the camera and display it in the same UI as that sample. This enables the user to immediately have a visual of the UltraHDR image captured by the camera.

However, currently when using the emulator, the image generated is not UltraHDR, so the sample has also been updated to reflect that by removing the options to show UltraHDR or gain map:

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@madebymozart madebymozart added enhancement New feature or request new sample This denotes the creation of a new sample in the platform samples app labels Jul 11, 2023
@madebymozart madebymozart self-assigned this Jul 11, 2023
@madebymozart madebymozart merged commit cd3a84a into main Jul 11, 2023
4 checks passed
@madebymozart madebymozart deleted the ultrahdr-capture-camera2 branch July 11, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new sample This denotes the creation of a new sample in the platform samples app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants