Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sample] [Graphics] UltraHDR Image Edit Operations #88

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

MayuriKhinvasara
Copy link
Contributor

Description
This CL contains sample code for editing an UltraHDR Images (on API 34 and above) with operations like crop, scale, rotate.

How Has This Been Tested?
Test Configuration #1 - Pixel 7 Pro API 34 Beta (Android 14 Beta)

Checklist
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation

Demo
The demo shows spatial edit operations like crop, scale, rotate on an ultrahdr image.
https://github.com/android/platform-samples/assets/5299872/3f4a7eb0-8833-466d-8a09-c9b7a6a8da82

Screenshots
ultra_hdr_list_edit

ultra_hdr_edit

@MayuriKhinvasara MayuriKhinvasara added enhancement New feature or request new sample This denotes the creation of a new sample in the platform samples app labels Aug 28, 2023
@MayuriKhinvasara MayuriKhinvasara self-assigned this Aug 28, 2023
@MayuriKhinvasara MayuriKhinvasara changed the title UltraHDR Image Edit Operations [Sample] [Graphics] UltraHDR Image Edit Operations Aug 28, 2023
Copy link
Contributor

@madebymozart madebymozart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

}

private fun Bitmap.rotate(): Bitmap {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space

visualizeEditedGainmap(editedBitmap),
)
}
//Release memory
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for comments just have a space after the "//"

@MayuriKhinvasara MayuriKhinvasara merged commit ccb3852 into main Sep 1, 2023
4 checks passed
@yrezgui yrezgui deleted the ultrahdr_edit branch December 7, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new sample This denotes the creation of a new sample in the platform samples app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants