Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix window insets on ChatScreen with safeContentPadding() #77

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

cartland
Copy link
Contributor

The issue is more visible with 3 button navigation. The InputBar is obscured by the navigation bar.
Modifier.safeContentPadding() ensures that the ChatScreen is not obscured.

The issue is more visible with 3 button navigation.
The InputBar is obscured by the navigation bar.
Modifier.safeContentPadding() ensures that the ChatScreen is not
obscured.
@cartland cartland requested a review from yaraki June 12, 2024 23:46
@cartland
Copy link
Contributor Author

Before:
0-Before

After:
1-After

@calren
Copy link
Contributor

calren commented Jun 13, 2024

adding sysui expert @ashnohe

@calren calren requested a review from ashnohe June 13, 2024 16:52
@ashnohe
Copy link
Contributor

ashnohe commented Jun 13, 2024

Thanks! Somehow this got removed from the main branch while we were working on the I/O codelabs.

This is the correct fix in ChatScreen around line 220:

InputBar(
    ...
    contentPadding = innerPadding.copy(layoutDirection, top = 0.dp), //Add this line.
    // contentPadding = innerPadding, // Remove this line.
    ...
 )

@cartland cartland removed the request for review from yaraki June 13, 2024 17:19
@cartland
Copy link
Contributor Author

@ashnohe thanks! I updated with your suggestion.

@cartland cartland marked this pull request as ready for review June 14, 2024 22:26
@cartland cartland merged commit 4e4fa72 into android:main Jun 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants