New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle wrapper validation #438
Conversation
818c8f6
to
2e71a5a
Compare
This PR also fixed missed orchestratorVersion for runner/AndroidTestOrchestratorWithTestCoverageSample. Hi @brettchabot , could you help to review this PR? Thanks. |
ccc1f75
to
8b51270
Compare
Hi @brettchabot , could you help to review this PR? Thanks. |
4b8f844
to
21993aa
Compare
Friendly ping @brettchabot , could you help to review this PR? Thanks. |
See https://github.com/gradle/wrapper-validation-action Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all Signed-off-by: utzcoz <utzcoz@outlook.com>
…ageSample ./gradlew wrapper --gradle-version 7.4 --distribution-type all Signed-off-by: utzcoz <utzcoz@outlook.com>
21993aa
to
9754b12
Compare
Friendly ping, hi @brettchabot @adazh , could you help review this PR? Thanks. |
Brett is out this week. @yuuki3655 Hi Yukki, would you be a good reviewer for this gradle change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this verification github action. It looks good to me.
See https://github.com/gradle/wrapper-validation-action
It is used by Robolectric many months.