Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gradle wrapper validation #438

Merged
merged 7 commits into from Jun 27, 2022

Conversation

utzcoz
Copy link
Contributor

@utzcoz utzcoz commented May 23, 2022

See https://github.com/gradle/wrapper-validation-action

It is used by Robolectric many months.

@utzcoz utzcoz force-pushed the add-gradle-wrapper-validation branch from 818c8f6 to 2e71a5a Compare May 23, 2022 14:42
@utzcoz
Copy link
Contributor Author

utzcoz commented May 23, 2022

This PR also fixed missed orchestratorVersion for runner/AndroidTestOrchestratorWithTestCoverageSample. Hi @brettchabot , could you help to review this PR? Thanks.

@utzcoz utzcoz force-pushed the add-gradle-wrapper-validation branch 2 times, most recently from ccc1f75 to 8b51270 Compare May 31, 2022 13:57
@utzcoz
Copy link
Contributor Author

utzcoz commented May 31, 2022

Hi @brettchabot , could you help to review this PR? Thanks.

@utzcoz utzcoz force-pushed the add-gradle-wrapper-validation branch 2 times, most recently from 4b8f844 to 21993aa Compare June 3, 2022 03:33
@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 12, 2022

Friendly ping @brettchabot , could you help to review this PR? Thanks.

./gradlew wrapper --gradle-version 7.4 --distribution-type all

Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all

Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all

Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all

Signed-off-by: utzcoz <utzcoz@outlook.com>
./gradlew wrapper --gradle-version 7.4 --distribution-type all

Signed-off-by: utzcoz <utzcoz@outlook.com>
…ageSample

./gradlew wrapper --gradle-version 7.4 --distribution-type all

Signed-off-by: utzcoz <utzcoz@outlook.com>
@utzcoz utzcoz force-pushed the add-gradle-wrapper-validation branch from 21993aa to 9754b12 Compare June 25, 2022 01:46
@utzcoz
Copy link
Contributor Author

utzcoz commented Jun 25, 2022

Friendly ping @brettchabot , could you help to review this PR? Thanks.

Friendly ping, hi @brettchabot @adazh , could you help review this PR? Thanks.

@adazh
Copy link
Collaborator

adazh commented Jun 27, 2022

Brett is out this week. @yuuki3655 Hi Yukki, would you be a good reviewer for this gradle change?

@yuuki3655 yuuki3655 self-requested a review June 27, 2022 21:10
Copy link
Collaborator

@yuuki3655 yuuki3655 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this verification github action. It looks good to me.

@yuuki3655 yuuki3655 merged commit 4d3f3f8 into android:main Jun 27, 2022
@utzcoz utzcoz deleted the add-gradle-wrapper-validation branch June 28, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants