Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

Commit

Permalink
Add sso to list of known schemes for relative URLs
Browse files Browse the repository at this point in the history
repo already special-cases sso:// URLs to behave similarly to https://
and rpc:// elsewhere in repo, but it forgot to do so here.

Noticed when trying to use relative URLs in a manifest obtained using
an sso:// URL.

Change-Id: Ia11469a09bbd6e444dbc4f22c82f9bbe9f5fd083
  • Loading branch information
joekilner authored and jrn committed Oct 27, 2016
1 parent 4d5bb68 commit 6e31079
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions manifest_xml.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,18 @@
LOCAL_MANIFESTS_DIR_NAME = 'local_manifests'

# urljoin gets confused if the scheme is not known.
urllib.parse.uses_relative.extend(['ssh', 'git', 'persistent-https', 'rpc'])
urllib.parse.uses_netloc.extend(['ssh', 'git', 'persistent-https', 'rpc'])
urllib.parse.uses_relative.extend([
'ssh',
'git',
'persistent-https',
'sso',
'rpc'])
urllib.parse.uses_netloc.extend([
'ssh',
'git',
'persistent-https',
'sso',
'rpc'])

class _Default(object):
"""Project defaults within the manifest."""
Expand Down

0 comments on commit 6e31079

Please sign in to comment.