Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readability improvement for JetStream sample app #142

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Readability improvement for JetStream sample app #142

merged 4 commits into from
Dec 4, 2023

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented Dec 1, 2023

This PR improves the readability by

  • Splitting some big composable functions into smaller ones.
  • Specifying actual values to the margins, width, and height instead of calculating from screen width / height, which was retrieved from LocalConfiguration.
  • Keeping the safe area for lazy lists by specifying contentPadding, instead of putting Spacer.

This PR also includes dependency updates.

mlykotom
mlykotom approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@mlykotom mlykotom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I have some small suggestions, this generally LGTM! 🎉

JetStreamCompose/gradle/libs.versions.toml Outdated Show resolved Hide resolved
JetStreamCompose/gradle/wrapper/gradle-wrapper.properties Outdated Show resolved Hide resolved
JetStreamCompose/jetstream/src/main/java/com/google/jetstream/presentation/common/MoviesRow.kt
showIndexOverImage: Boolean,
movie: Movie,
index: Int
index: Int,
modifier: Modifier = Modifier,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

...tstream/src/main/java/com/google/jetstream/presentation/screens/dashboard/DashboardScreen.kt
return@onPreviewKeyEvent true
}
false
BackPressHandledArea(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

...tstream/src/main/java/com/google/jetstream/presentation/screens/dashboard/DashboardScreen.kt Outdated Show resolved Hide resolved
@chikoski chikoski merged commit f5b23d9 into android:main Dec 4, 2023
1 of 2 checks passed
@dheineman dheineman mentioned this pull request Dec 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlykotom mlykotom mlykotom approved these changes

@Anupama65 Anupama65 Anupama65 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chikoski @mlykotom @Anupama65