cap1xxx - add support to specify alternate i2c address (#111) #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdkoren
approved these changes
Sep 14, 2018
devunwired
suggested changes
Sep 14, 2018
| /** | ||
| * Create a new Cap1xxx controller. | ||
| * | ||
| * @param i2cName I2C port name where the controller is attached. Cannot be null. | ||
| * @param i2cAddress 7-bit I2C address for the attached controller. Cannot be null. |
There was a problem hiding this comment.
int values cannot be null, I'd remove that phrase from the end.
| * framework. | ||
| * | ||
| * @param i2cName I2C port name where the controller is attached. Cannot be null. | ||
| * @param i2cAddress 7-bit I2C address for the attached controller. Cannot be null. |
There was a problem hiding this comment.
int values cannot be null, I'd remove that phrase from the end.
| * @throws IOException | ||
| */ | ||
| public Cap1xxx(String i2cName, String alertName, Configuration chip, Handler handler) throws IOException { | ||
| this(i2cName, I2C_ADDRESS, alertName, chip, handler); |
There was a problem hiding this comment.
This is a good change, but if we expose the I2C address as a parameter let's rename the constant to DEFAULT_I2C_ADDRESS to match our other drivers (example)
devunwired
suggested changes
Sep 14, 2018
| @@ -192,7 +192,7 @@ public Cap1xxx(Context context, String i2cName, String alertName, Configuration | |||
| } | |||
|
|
|||
| /** | |||
| * Create a new Cap1xxx controller. | |||
| * Create a new Cap12xx controller with the default I2C address. | |||
|
I believe all requested changes are made @devunwired |
devunwired
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cap1xxx range support multiple i2c addresses which are used across our various boards- GFX HAT, Display-o-tron HAT, Drum HAT, Piano HAT, etc- this patch adds support for specifying an i2c address
See #111 for details.