Fix grammar and wording in documentation #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
repeatOnLifecycle() makes sense for a cold flow. However, for hot `SharedFlow` and `StateFlow`, they are likely to run on a different coroutineScope such as `viewModelScope`, which is different from the collector's launching lifecycleScope. Therefore I renamed `uiStateFlow` to `uiDataFlow`, since the former can be easily mistakenly understood as a `StateFlow` for UI.
|
Originally I included a renaming:
On second thought, this is not an issue for |
jbw0033
approved these changes
Jul 15, 2021
jossiwolf
pushed a commit
to jossiwolf/androidx
that referenced
this pull request
Jul 16, 2021
## Proposed Changes - Grammar fix: Adding a `}` ## Testing Test: None, since this is documentation This is an imported pull request from androidx#205. Resolves androidx#205 Github-Pr-Head-Sha: f4ba6b1 GitOrigin-RevId: b9f6400 Change-Id: Iefd9b1d0d8aa7ce7f61b5eb82aae06833ce14d4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
}Testing
Test: None, since this is documentation