Find best matched font in TypefaceCompatApi29Impl #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use best-matched font rather than "hardcoded"
The original part
This will make the final
Typeface
ALWAYS have either 400 (FONT_WEIGHT_NORMAL) or 700 (FONT_WEIGHT_BOLD) weight. It is incorrect since fonts passed to these methods could have other font-weight. For example, pass only one font with 500 weight, the finalTypeface
will have 400 weight, making the fallback font displayed as 400 weight rather than 500.This pull request copies the platform's algorithm to find the best-match font from the font family.
Testing
Test: Observed that the font weight is correct
Issues Fixed
Fixes: Fix https://issuetracker.google.com/issues/194553426