Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make testutils-paging a KMP #578

Closed

Conversation

veyndan
Copy link
Contributor

@veyndan veyndan commented Jun 30, 2023

Test: ./gradlew test connectedCheck
Bug: 270612487

@claraf3
Copy link
Member

claraf3 commented Jun 30, 2023

Are we going to move jvm-free files to common later?

@veyndan
Copy link
Contributor Author

veyndan commented Jun 30, 2023

That's the plan! We can move them over to commonMain when the dependent classes in paging-common have been moved over to commonMain.

@veyndan veyndan force-pushed the 270612487/kmp-testutils-paging branch from 7328dab to fc94e33 Compare July 4, 2023 21:06
@veyndan
Copy link
Contributor Author

veyndan commented Jul 4, 2023

@claraf3 Moved classes over to commonMain!

@veyndan veyndan changed the title Make testutils-paging a KMP, with only a JVM implementation Make testutils-paging a KMP Jul 4, 2023
@veyndan veyndan force-pushed the 270612487/kmp-testutils-paging branch from fc94e33 to 0b0b9bf Compare July 4, 2023 21:19
@veyndan veyndan force-pushed the 270612487/kmp-testutils-paging branch from 0b0b9bf to 0cfc844 Compare July 4, 2023 21:22
@copybara-service copybara-service bot closed this in 89b052d Jul 5, 2023
@veyndan veyndan deleted the 270612487/kmp-testutils-paging branch July 5, 2023 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants