Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make paging-testing multiplatform by moving everything to common* #609

Closed
wants to merge 3 commits into from

Conversation

veyndan
Copy link
Contributor

@veyndan veyndan commented Sep 9, 2023

Test: ./gradlew paging:paging-testing:allTests

@veyndan
Copy link
Contributor Author

veyndan commented Sep 9, 2023

CI should be fixed by https://android-review.googlesource.com/c/platform/frameworks/support/+/2746657. I'll rebase this PR once that has been merged.

Copy link
Member

@claraf3 claraf3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@claraf3 claraf3 requested review from ianhanniballake and removed request for yigit and dlam September 11, 2023 17:52
@dlam
Copy link
Member

dlam commented Sep 11, 2023

Copybara is having trouble mirroring this because of the conflict.

@claraf3
Copy link
Member

claraf3 commented Sep 11, 2023

Infra recently upgraded their build and changed androidTest references to androidUnitTest. Can you please try rebasing?

@veyndan
Copy link
Contributor Author

veyndan commented Sep 11, 2023

Rebased!

@veyndan veyndan deleted the paging-testing branch September 11, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants