Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Compose] Vertical chain Top and Bottom margins ignored. #572

Closed
oscar-ad opened this issue Apr 19, 2022 · 0 comments · Fixed by #573
Closed

[Compose] Vertical chain Top and Bottom margins ignored. #572

oscar-ad opened this issue Apr 19, 2022 · 0 comments · Fixed by #573
Assignees
@oscar-ad
Labels
bug Something isn't working

Comments

@oscar-ad
Copy link
Collaborator 

constraint(createVerticalChain(...)) {
   top.linkTo(parent.top, 10.dp)
}

The margin defined when constraining a vertical Chain seems to be ignored. Horizontal chains are working as expected.
@oscar-ad oscar-ad added the bug Something isn't working label Apr 19, 2022
@oscar-ad oscar-ad self-assigned this Apr 19, 2022
oscar-ad added a commit to oscar-ad/constraintlayout that referenced this issue Apr 19, 2022
@oscar-ad
[Compose] Fix margin for Chain first and last elements
429f716 
Fixes androidx#572

The margin for constraints that can be declared for chains would not be
applied for VerticalChains.

Also applies the gone margin, which was ignored for both kinds of
Chains.
@oscar-ad oscar-ad mentioned this issue Apr 19, 2022
Merged
oscar-ad added a commit that referenced this issue Apr 21, 2022
@oscar-ad
[Compose] Fix margin for Chain first and last elements
3fcc360 
Fixes #572

The margin for constraints that can be declared for chains would not be
applied for VerticalChains.

Also applies the gone margin, which was ignored for both kinds of
Chains.
oscar-ad added a commit that referenced this issue May 19, 2022
@oscar-ad
[Compose] Fix margin for Chain first and last elements
6fdd704 
Fixes #572

The margin for constraints that can be declared for chains would not be
applied for VerticalChains.

Also applies the gone margin, which was ignored for both kinds of
Chains.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscar-ad oscar-ad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Compose] Fix margin for Chain first and last elements oscar-ad/constraintlayout
1 participant
@oscar-ad