CMCD data as query parameter is url-encoded twice #1075
Assignees
Labels
Comments
|
Thanks for spotting, I can reproduce this behaviour, I'll send a fix for review. |
copybara-service bot
pushed a commit
that referenced
this issue
Feb 7, 2024
`Uri.appendQueryParameter` is documented to encode its arguments, so calling `Uri.encode` beforehand results in double-encoding. Issue: #1075 #minor-release PiperOrigin-RevId: 604995441
copybara-service bot
pushed a commit
to google/ExoPlayer
that referenced
this issue
Feb 7, 2024
`Uri.appendQueryParameter` is documented to encode its arguments, so calling `Uri.encode` beforehand results in double-encoding. Issue: androidx/media#1075 #minor-release PiperOrigin-RevId: 604995441
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Version
Media3 1.2.1
More version details
No response
Devices that reproduce the issue
All devices
Devices that do not reproduce the issue
No response
Reproducible in the demo app?
Not tested
Reproduction steps
Expected result
CMCD data included in the url as query-parameters and url-encoded
Actual result
This is an example of a CMCD query-parameter.
CMCD=bl%253D20200%252Cbr%253D6000%252Cd%253D3840%252Cdl%253D20200%252Cmtp%253D57500%252Cot%253Dv%252Csf%253Dd%252Cst%253Dl%252Ctb%253D6000
Is seems like it's url-encoded twice. Is that done intentially?
Media
N/A
Bug Report
adb bugreportto android-media-github@google.com after filing this issue.The text was updated successfully, but these errors were encountered: