Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultNotificationProvider picks unreasonable icon #66

Closed
tzugen opened this issue Apr 1, 2022 · 1 comment
Closed

DefaultNotificationProvider picks unreasonable icon #66

tzugen opened this issue Apr 1, 2022 · 1 comment
Assignees
@christosts
Labels
bug

Comments

@tzugen
Copy link

tzugen commented Apr 1, 2022

The DefaultNotificationProvider uses the application launcher icon (context.getApplicationInfo().icon)

Modern Notifications only take the alpha channel of the supplied icon. Unless the ic_launcher icon has transparency th notification will only be white.

Suggestion: default to using ic_notification..
@marcbaechinger
Copy link
Contributor

Closing as this is fixed and will be included in 1.0.0-beta01 which is on its way to be released.

marcbaechinger added a commit that referenced this issue May 31, 2022
@marcbaechinger
Use resource ID from drawable.xml as the notification icon
839d4f4 
Issue: #66
Issue: #65

#minor-release

PiperOrigin-RevId: 452004492
marcbaechinger added a commit that referenced this issue Jun 15, 2022
@marcbaechinger
Use resource ID from drawable.xml as the notification icon
ad5788e 
Issue: #66
Issue: #65

#minor-release

PiperOrigin-RevId: 452004492
(cherry picked from commit 839d4f4)
@androidx androidx locked and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@christosts christosts

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marcbaechinger @christosts @tzugen