Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown menu does not fit in window, requires horizontal scrolling #17

Open
JeffryErickson opened this issue Jun 2, 2016 · 41 comments
Open

Dropdown menu does not fit in window, requires horizontal scrolling #17

JeffryErickson opened this issue Jun 2, 2016 · 41 comments
Assignees
@andryou
Labels
bug

Comments

@JeffryErickson
Copy link

When I click the ScriptSafe icon, the dropdown menu does not fit within the dropdown window. I have to use the slider at the bottom of the window to see the whole thing. This does not happen with other add-ins. Very occasionally (but not usually) if I change the zoom level of the browser tab before I click the ScriptSafe icon, this problem goes away. I have attached a screenshot.

I am on Chrome (V 51.0.2704.79 m) on Windows 7, ScriptSafe V 1.0.7.4.

This seems similar to issue #7 but different enough I thought I wouldn't hijack that issue.
2016-06-02 andryou_scriptsafe screen shot
@andryou
Copy link
Owner

andryou commented Jun 2, 2016

Yikes, will fix and push out an update asap. Thanks!

@andryou
Copy link
Owner

andryou commented Jun 2, 2016

I've just pushed v1.0.7.5. Please let me know if this issue is fixed after updating :)

@andryou andryou added the bug label Jun 2, 2016
@andryou andryou self-assigned this Jun 2, 2016
@JeffryErickson
Copy link
Author

Thanks for the quick attention, but unfortunately it is still showing the same symptoms.

@andryou
Copy link
Owner

andryou commented Jun 2, 2016 •
edited

Do you remember which version it was displaying properly in? Also did you try restarting Chrome?

@JeffryErickson
Copy link
Author

I have tried restarting Chrome. It has been a problem for quite a few days, but not weeks but I did not think to check the version when it first started happening.

@andryou
Copy link
Owner

andryou commented Jun 2, 2016

Thanks, I'm working on making some minor CSS tweaks and will push an update in a couple hours or tomorrow.

Side-note: something strange I noticed is that the footer in the panel in your screenshot is that of v1.0.7.3 (with the "Quick Start | Overview" links that I changed to "Documentation" in v1.0.7.4)

@andryou
Copy link
Owner

andryou commented Jun 4, 2016

New update v1.0.7.7 pushed out. Please try and close this issue if it's working for you :)

@JeffryErickson
Copy link
Author

Sorry, but it still is happening!

@andryou andryou closed this as completed in 3b076cf Jun 5, 2016
@andryou andryou reopened this Jun 5, 2016
@andryou
Copy link
Owner

andryou commented Jun 6, 2016

Please try v1.0.7.8 and close this issue if resolved, thanks!

@andryou
Copy link
Owner

andryou commented Jun 6, 2016

(sorry for the delay in getting v1.0.7.8 to you; it's been "Pending Review" in the Chrome Web Store since I pushed it out 8:45pm eastern yesterday)

@andryou
Copy link
Owner

andryou commented Jun 7, 2016

I've been refreshing the Developer Dashboard all day to check on the status and I'm happy to announce v1.0.7.8 has been published on the Chrome Web Store within the past half hour.

@JeffryErickson
Copy link
Author

It is better - I can see more of the dropdown menu but still not all. I still have to scroll to the right to get to the X to close the window (although I usually just click outside the menu)..

@andryou
Copy link
Owner

andryou commented Jun 7, 2016

Good to hear there's some improvement, can you please post a screenshot so I can gauge the values? Thanks!

@JeffryErickson
Copy link
Author

Here is a new screenshot.
scriptsafe dropdown menu 2016-06-07 12_31_28

@andryou
Copy link
Owner

andryou commented Jun 7, 2016

Thanks, do you have your system font set to 125% or 150%? And if so, which value?

2016-06-07 17_43_56

Just wondering so I can set my machine to the same to debug this. Thanks!

@JeffryErickson
Copy link
Author

Windows is set at medium, 125%. I have Chrome set zoomed as well, but it looks like that might vary by tab. A new default tab comes in at 125%

@andryou
Copy link
Owner

andryou commented Jun 11, 2016

@JeffryErickson has this improved for you in any way with the latest updates?

@JeffryErickson
Copy link
Author

No, sorry! (I am on .7.10 now)

@MaWo123
Copy link

MaWo123 commented Jan 19, 2017

I have the same problem...is there any solution by now?

@JeffryErickson
Copy link
Author

I still have the problem, too.

@andryou
Copy link
Owner

andryou commented Jan 19, 2017

Which ScriptSafe version are you both on? The panel has been updated to a one-column layout as of v1.0.9.0.

I just tested it with my system font set at 125%:

2017-01-19 10_33_14
(please disregard the version in the screenshot)

Are there any other settings that you've modified?

@JeffryErickson
Copy link
Author

JeffryErickson commented Jan 19, 2017 •
edited

I am on version 1.0.8.5. I tried updating but Chrome is not pulling in v1.09. My system font is also at 125%. I believe my ScriptSafe options are all at their defaults.

I like the one-column layout!

@andryou
Copy link
Owner

andryou commented Jan 19, 2017

@JeffryErickson please let me know when v1.0.9.0 is propagated to your machine :) I'm hoping that the one-column layout resolves the horizontal spanning issue!

@JeffryErickson
Copy link
Author

I uninstalled and re-installed and am now on v1.0.9.0 - but the problem remains unfortunately :(
scripsafe page fit

@andryou
Copy link
Owner

andryou commented Jan 19, 2017

Thanks; I think I have an idea of how to resolve this, I'll look into it today and I'll keep you updated!

@MaWo123
Copy link

MaWo123 commented Jan 19, 2017 •
edited

I have a chrome skin, but i also tried to turn it off. no change. systemfont is 100%. also i just noticed, i dont have the 3 buttons (Allow all blocked for Session etc)

scriptsave

@andryou
Copy link
Owner

andryou commented Jan 19, 2017 •
edited

I've worked on converting the font sizes and widths to be fluid and created a test build for you to try on your machines.

Could you both do me a favour and test it out? https://dl.dropboxusercontent.com/u/784305/scriptsafe_test.zip

Thank you! Instructions on how to install it:

  1. Extract the ZIP file to its own folder anywhere on your computer
  2. Copy and paste chrome://extensions into your browser address bar and press Enter
  3. Make sure you have disabled the Chrome Web Store version of ScriptSafe (ID: oiigbmnaadbkfbmpbfijlflahbdbdgdf)
  4. Enable “Developer Mode“
  5. Click on Load unpacked extension, navigate to the folder you extracted ScriptSafe to in step 1 and click on OK

Then please open a site and open the ScriptSafe panel and let me know if there is any improvement.

Once done testing, you can simply remove the test ScriptSafe build and re-enable the Chrome Web Store version.

@MaWo123
Copy link

MaWo123 commented Jan 20, 2017

Yes! That is working perfectly. Everything fits in the dropdown window. thank you :)
The only thing for me now is that i somehow dont have the 3 buttons that you have in your screenshots (Allow all blocked for Session, Revoke page temp permissions and revoke all temp)

@andryou
Copy link
Owner

andryou commented Jan 20, 2017

That's great to hear! :)

Allow all blocked for Session = appears when items have been blocked on a tab. Try going to www.cnn.com and click on "Temporary" to allow external resources to load, then open the panel again and this should appear.

Revoke page temp permissions and revoke all temp = if you temporarily allow something in a tab, these two buttons will appear. If you're on a tab with nothing temporarily allowed, but you have temporarily allowed something in a different tab, only "Revoke All Temp" will appear.

@MaWo123
Copy link

MaWo123 commented Jan 20, 2017 •
edited

ahhh nice, never noticed that before, because i would've had to scoll down^^

looking forward to the next version....and thanks again for the really fast support

@JeffryErickson
Copy link
Author

Your test build worked perfectly - great!
Thanks for being responsive!

@andryou andryou mentioned this issue Jan 23, 2017
Closed
@andryou
Copy link
Owner

andryou commented Jan 23, 2017 •
edited

v1.0.9.1 Beta is now available for testing: #166

@JeffryErickson
Copy link
Author

I loaded the Beta and everything seems to work perfectly so far. I can see the entire drop-down window. Great!

@andryou
Copy link
Owner

andryou commented Jan 26, 2017

v1.0.9.1 has been published in the Chrome and Opera stores which addresses this issue. Thanks again for your report and testing!

@andryou andryou closed this as completed Jan 26, 2017
@JeffryErickson
Copy link
Author

JeffryErickson commented Jan 27, 2017 •
edited

Sorry to bear bad news. v1.0.9.1 BETA worked, v1.0.9.1 non-beta does not. Screen shots attached. I restarted Chrome between each version. Advice? (I just registered as a Beta tester at 3.37 pm central.)
scriptsafe v1 0 9 1 beta
scriptsafe v1 0 9 1

@andryou
Copy link
Owner

andryou commented Jan 29, 2017

@JeffryErickson very interesting! Thank you for retesting. I will re-open this issue.

I just compared the changes between v1.0.9.1 beta and the stable version: v1.0.9.1_beta...master

The only change I made was removing 5 pixels from the top of the panel, bringing the tab domain box closer to the ScriptSafe heading.

Could you try downloading v1.0.9.1 from https://github.com/andryou/scriptsafe/releases/tag/v1.0.9.1 and loading it into Chrome following the same instructions I provided earlier in this ticket, and let me know if the panel still has the issue? (#17 (comment))

If it displays properly, then it sounds like there is a weird bug in Chrome with local extensions vs extensions added from the Web Store.

@andryou andryou reopened this Jan 29, 2017
@JeffryErickson
Copy link
Author

JeffryErickson commented Jan 29, 2017 •
edited

It looks like "weird bug" is right. I loaded the extension from Github and the problem goes away. In fact I can toggle on and off the local extension vs the Web Store extension and the problem comes and goes with it!
One other thing I haven't noted before: The width and height of the window in the local extension are about 2/3 as big as the Web Store extension. On the same web site, the Web Store drop down is 1009 x 313 Pixels and the local extension is 726 x 193.

@MaWo123
Copy link

MaWo123 commented Feb 17, 2017

anything new ? still have the same bug if i use the normal release...currently using the beta but my browser tell me everytime that i shouldn't use it in developer mode.

@MaWo123
Copy link

MaWo123 commented Apr 1, 2017

still the same bug. and the beta version somehow uninstalled itself.

@MaWo123
Copy link

MaWo123 commented Apr 19, 2017

anything new?

@w8n41
Copy link

w8n41 commented Mar 23, 2018

This is exactly the same thing I am experiencing. The menu continues to be broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andryou andryou

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@andryou @JeffryErickson @MaWo123 @w8n41