Skip to content
This repository has been archived by the owner on Jun 10, 2019. It is now read-only.

[RFC] [WIP] Abstract release information out of the code #455

Closed
wants to merge 1 commit into from

Conversation

drts01
Copy link
Contributor

@drts01 drts01 commented Feb 10, 2018

I think it would be a better practice to store the release information outside of the code. This is my initial attempt at that. I would like feedback on my approach and if I am going down the correct path.

@andsens
Copy link
Owner

andsens commented Feb 10, 2018

Right on! That's quite a task to take on. Kudos!
I think your approach is the right one here. Creating yaml files for what the different distros look like is a nice way to handle this and makes it easy for others to understand.
I am however a little uncertain whether that approach can be applied consistently throughout the project. You might run into scenarios where one distro requires some more logic than a simple yaml key lookup to be configured correctly while the others are plain and simple. I wouldn't call that a dealbreaker though. It's just important to remember to use the coding escape-hatch at the right time so that you don't end up implementing complex decision trees in a yaml file.

@drts01 drts01 closed this Feb 19, 2018
@drts01 drts01 deleted the no-hardcode-releases branch February 19, 2018 02:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants