Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Russian and Ukrainian locales #4

Merged
merged 2 commits into from Jun 10, 2022
Merged

Conversation

leamare
Copy link
Contributor

@leamare leamare commented Jun 10, 2022

No description provided.

@andsfonseca
Copy link
Owner

@leamare, can you put these files in the "lang" folder of the application and see if it worked?

  • Open task manager
  • Go to services tab
  • Search for dota-2-rpc
  • Right click and press restart.
  • Open Dota 2 and open the hero demo

If you can send a print that would be great.

@leamare
Copy link
Contributor Author

leamare commented Jun 10, 2022

I tested it with Russian (since it's the system language on my laptop) and it seemed to work. Should work with Ukrainian without a problem too, though I can't really test it.

image

As a side note, adding more to #3: it would be nice to be able to override preferred language (e.g. I have system language set as ru-RU, but my Steam and Discord are en-US and I would like to keep it this way for the dota RPC as well).

@andsfonseca
Copy link
Owner

@leamare Thx. I'll merge

@andsfonseca
Copy link
Owner

Note: I will create another issue related to the discord language

@andsfonseca andsfonseca merged commit 29da1ea into andsfonseca:master Jun 10, 2022
@andsfonseca andsfonseca added translation Improvements or additions to the translation implemented An improvement has been implemented labels Jun 12, 2022
@andsfonseca andsfonseca added this to the DotA 2 RPC v1.0.3 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented An improvement has been implemented translation Improvements or additions to the translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants