Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out replies not to me or my friends from Home timeline #160

Closed
Dragnucs opened this issue Nov 10, 2014 · 25 comments
Closed

Filter out replies not to me or my friends from Home timeline #160

Dragnucs opened this issue Nov 10, 2014 · 25 comments
Milestone

Comments

@Dragnucs
Copy link

It would be very practical to have an option that allows us to hide replies to people we are not subscribed to.

For example I am subscribed to A but not to to B. A is subscribed to B. If A replies to B, I don't want to see this reply/notice.

@moshpirit
Copy link
Contributor

I don't think this would be possible, in my view, it's a social network thing, it doesn't matter what client do you use.
The only thing I think that AS could do it's to let you hide some notes, but you had to do it manually.

@Dragnucs
Copy link
Author

Of course. This should be implemented in ostatus or gnusocial API where we ask it to hide this kind of notices. That way it would even be band with friendly for small servers and mobile devices.

But I am asking it here because it is easy to do as it just implies some basic verifications.

If the gnusocial developers sees it here they might like it and implemente it. I am going to have them look at this thread in the evening.

@moshpirit
Copy link
Contributor

I don't think the GS developers read this, but you can also write in GNU social using !gs and !gnusocial groups. But the best way, in my opinion, it's writing it in its Gitorious website :-)

@yvolk
Copy link
Member

yvolk commented Nov 10, 2014

@Dragnucs I remember you proposed something like this in GNU Social discussion?! (I couldn't find that thread...)
This additional filter to the Home timeline is not hard to implement. I guess this filtering should be done during syncing. This way unwanted messages will not be stored in the local database.
New option "Filter out replies not to myself from Home timeline" will be added to the Settings - Syncing.

@moshpirit
Copy link
Contributor

Great!! What about an usual filter? I thought I opened an issue, but I can't find it.
Uses of the filter:

  • Highlight some posts with filtered words. (e.g. Andstatus -> all the notes with "Andstatus will be highlighted (or even notified))
  • Hide some other posts with another filtered words. (e.g. NSFW -> all the notes with "NSFW" won't appear anymore in our timeline (except if it appears in a mention))

Should I open a new issue for that?

@yvolk
Copy link
Member

yvolk commented Nov 10, 2014

@moshpirit I guess these should be different "issues". I would call your wish a "Custom filters for Home timeline" (include or exclude...)

@Dragnucs
Copy link
Author

@yvolk It would be better if it was "Filter out replies not to myself or friends from Home timeline". But as you said is good enough.

Thank you for your responsiveness.

@yvolk
Copy link
Member

yvolk commented Nov 11, 2014

@Dragnucs Agree, this should be "Filter out replies not to myself or my friends from Home timeline".
I renamed the Issue accordingly.

@yvolk yvolk changed the title Hide replies to not subscribed to account. Filter out replies not to myself or my friends from Home timeline Nov 11, 2014
@yvolk yvolk modified the milestone: Filters Sep 27, 2015
@yvolk yvolk changed the title Filter out replies not to myself or my friends from Home timeline Filter out replies not to me or my friends from Home timeline Oct 11, 2015
@yvolk
Copy link
Member

yvolk commented Oct 11, 2015

@Dragnucs @moshpirit You may start testing this new feature building from the Source code.

@vinzv
Copy link
Contributor

vinzv commented Oct 12, 2015

Thanks for implementing! It works quite well with "real" replies. If there's not thread and the message starts with an @ symbol it doesn't grab it. Maybe that's a thing for another option like "Hide @-replies"?

img_20151012_223252

@moshpirit
Copy link
Contributor

I can't right now, I'm using an old device these days :(

@yvolk
Copy link
Member

yvolk commented Oct 13, 2015

@vinzv "Hide @-replies" as an addition to "Hide replies..." looks like of a too narrow usage to me...

@vinzv
Copy link
Contributor

vinzv commented Oct 13, 2015 via email

@yvolk
Copy link
Member

yvolk commented Oct 13, 2015

I thought about this: this is not easy for GNU Social, when @username is used instead of Webfinger ID: it may refer to different people... but I may implement a simple/fast approach, matching as friends all @usernames (and thus not hiding them).
HTML formatting may also interfere here, I'm afraid that stripping HTML on the fly may be too long.
Anyway, I will test this.

@Dragnucs
Copy link
Author

Isn't there a text version that accompanies each notice?

On Tue, 13 Oct, 2015 at 5:25 PM, Yuri Volkov notifications@github.com
wrote:

I thought about this: this is not easy for GNU Social, when @username
is used instead of Webfinger ID: it may refer to different people...
but I may implement a simple/fast approach, matching as friends all
@usernames (and thus not hiding them).
HTML formatting may also interfere here, I'm afraid that stripping
HTML of the fly may be too long.
Anyway, I will test this.


Reply to this email directly or view it on GitHub.

@yvolk
Copy link
Member

yvolk commented Oct 13, 2015

@Dragnucs Currently I implemented the filter for a Timeline view only. All messages, even "hidden", are stored in a local database.
So only one version of a message text is stored. And I am analyzing it on the fly... I thought now that stripping HTML before applying filters is needed for "Hide messages based on keywords" also, because it's not correct to filter by hidden HTML content...
...maybe I will go as far as to actually add another "plain text" column to a message table in order to use it for Search also?!

@Dragnucs
Copy link
Author

Can't you filter them based on a regex that matches the text format OR
the HTML format?

On Tue, 13 Oct, 2015 at 5:36 PM, Yuri Volkov notifications@github.com
wrote:

@Dragnucs Currently I implemented the filter for a Timeline view
only. All messages, even "hidden", are stored in a local database.
So only one version of a message text is stored. And I am analyzing
it on the fly... I thought now that stripping HTML before applying
filters is needed for "Hide messages based on keywords" also, because
it's not correct to filter by hidden HTML content...
...maybe I will go as far as to actually add another "plain text"
column to a message table in order to use it for Search also?!


Reply to this email directly or view it on GitHub.

@yvolk
Copy link
Member

yvolk commented Oct 13, 2015

@Dragnucs Could you give an example, I'm afraid didn't get you :-)

@Dragnucs
Copy link
Author

/^(@\w+|<a .+>@\w+)/

On 13 October 2015 19:45:32 WEST, Yuri Volkov notifications@github.com wrote:

@Dragnucs Could you give an example, I'm afraid didn't get you :-)


Reply to this email directly or view it on GitHub:
#160 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@yvolk
Copy link
Member

yvolk commented Oct 18, 2015

@vinzv I made it possible to filter replies to a User, which are not replies to a message.
If a message is not a Reply to another message, AndStatus checks if the message's body starts with @username and marks it as a Reply to a User with this username. So such "Replies to a User" are also filtered by this option

Please note that this new behaviour works only for messages, downloaded after installation of AndStatus v.20.1. (134)

v.20.1. Published at the Open Beta testing channel, please opt in here: https://play.google.com/apps/testing/org.andstatus.app

@Dragnucs
Copy link
Author

Good.

On dim., 18 oct., 2015 at 7:48 , Yuri Volkov notifications@github.com
wrote:

@vinzv I made it possible to filter replies to a User, which are not
replies to a message.
If a message is not a Reply to another message, AndStatus checks if
the message's body starts with @username and marks it as a Reply to a
User with this username. So such "Replies to a User" are also
filtered by this option

Please note that this new behaviour works only for messages,
downloaded after installation of AndStatus v.20.1. (134)

v.20.1. Published at the Open Beta testing channel, please opt in
here: https://play.google.com/apps/testing/org.andstatus.app


Reply to this email directly or view it on GitHub.

@moshpirit
Copy link
Contributor

931 errors on AIDE 3.2 :(
Bq M5 - Android 5.0.2

@yvolk
Copy link
Member

yvolk commented Oct 19, 2015

@moshpirit Please see #277 regarding compilation.

@moshpirit
Copy link
Contributor

Oh, I didn't see your comment! thanks!

yvolk added a commit that referenced this issue Oct 19, 2015
@yvolk
Copy link
Member

yvolk commented Nov 20, 2015

Implemented in v.20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants