Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of back button/key #253

Closed
vinzv opened this issue Apr 8, 2015 · 14 comments
Closed

Behavior of back button/key #253

vinzv opened this issue Apr 8, 2015 · 14 comments

Comments

@vinzv
Copy link
Contributor

vinzv commented Apr 8, 2015

When I search for something and I want to go back to main timeline the back button/key closes AndStatus despite going back as expected. Same thing for going back from Mentions to main timeline.
I think that's no big problem but a bit confusing compared to other (social networking) apps.

@yvolk
Copy link
Member

yvolk commented Apr 8, 2015

Actually a User has a clue when he is on a Home screen: no Up button on an Action bar.
But I agree that maybe we should have a "Default Timeline" as suggested in #236, and Back button would return to this timeline first?!

@yvolk
Copy link
Member

yvolk commented Apr 8, 2015

BTW, Back and Up buttons are not the same...
Edited: see https://developer.android.com/design/patterns/navigation.html

@clacke
Copy link

clacke commented Dec 21, 2015

Agree, back button should go back from current view state to previous view state. If I change the view state and back button closes the app, that's confusing -- especially when in a "custom" mode like search. I have closed AndStatus many times due to this.

@yvolk
Copy link
Member

yvolk commented Dec 22, 2015

@clacke I recently thought about allowing the Timeline Activity to have multiple instances. The main problem, which we may face in that case, will be "Out of memory" error.
Anyway, I will definitely try this. Now I'm redoing Timeline content loaders #313 , so this change, maybe as an option, looks like natural...

@yvolk
Copy link
Member

yvolk commented Feb 8, 2016

I think that we don't need multiple instances of a Timeline. We could just remember a history of timeline switching. And go back that history (switching in reverse direction...)

@bulletbites
Copy link

I just posted #356 which is pretty much the same issue. Is it not possible to have a "home/back-option with the home setting being the default TL position?

@ghost
Copy link

ghost commented Sep 30, 2016

referred of #422

Yes, I think we mean the same.

I summarize again:

This symbol is above if I am the start time line on. on the left:

11

I have this back arrow at many but not all undersides:

22

It would simplify the navigation very much if this arrow on every underside existed.

@yvolk
Copy link
Member

yvolk commented Oct 1, 2016

@b2410 What you show on your screenshots is "Up" button, which is about navigation in a hierarchy of views (e.g. navigation from a Conversation view to a Timeline).
"Back" button is (usually) a hardware button below the device's display. That button is about history of navigation between views (e.g. history of switching between different timelines of AndStatus).

Please read this carefully: https://developer.android.com/design/patterns/navigation.html (I did this right now...)

Taking that Android guidelines and terminology into account I think that "Up" button, which you showed above, works correctly (at least in most cases...).
What definitely needs to be improved - the dedicated (usually hardware) "Back" button, which generally looks like this:
back_button
or like this (onscreen Back button):
back_button_android-7

yvolk added a commit that referenced this issue Oct 1, 2016
…avigation, in reverse chronological order, through the history of screens the user has recently worked with. See https://developer.android.com/design/patterns/navigation.html

Return to the Default timeline clears the whole history stack, so when a User presses "Back" button on the Default timeline, he/she leaves AndStatus (and returns usually to the Home screen of the Device).
yvolk added a commit that referenced this issue Oct 1, 2016
@ghost
Copy link

ghost commented Oct 1, 2016

Excuses my mistake. I have never noticed the difference.

It is working now as described in the link. But on the user timeline is the problem that the "up" button not exit and the "back" button close andstatus.

@yvolk
Copy link
Member

yvolk commented Oct 3, 2016

Implemented in v.30.00. Please test: the Open Beta testing channel https://play.google.com/apps/testing/org.andstatus.app

@ghost
Copy link

ghost commented Oct 3, 2016

@yvolk It functions perfectly. Thank you.

@yvolk
Copy link
Member

yvolk commented Oct 3, 2016

@b2410 Actually the change was trivial. Why I didn't do this earlier: I was afraid that this would cause out of memory issues. Please report if you have them after this change.

@ghost
Copy link

ghost commented Oct 8, 2016

@yvolk I test it 5 days without problems. The app or the phone was not restarted. More Ram is not required.

@yvolk
Copy link
Member

yvolk commented Oct 8, 2016

@b2410 Thank you for the feedback!

@yvolk yvolk closed this as completed Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants