Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subvolume_charge.sh]: Fix Argument Parsing #89

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

andthum
Copy link
Owner

@andthum andthum commented Nov 4, 2022

[subvolume_charge.sh]: Fix Argument Parsing

Type of Change

  • Bug fix.
  • New feature.
  • Code refactoring.
  • Dependency update.
  • Documentation update.
  • Maintenance.
  • Other: Description.
  • Non-breaking (backward-compatible) change.
  • Breaking (non-backward-compatible) change.

Motivation and Context

binwidth was read from the 9th positional argument (like every) although it must be read from the 10th positional argument.

Proposed Changes

Read binwidth from the 10th positional argument.

PR Checklist

  • I followed the guidelines in the Developer's Guide.
  • New/changed code is properly tested.
  • [~] New/changed code is properly documented.
  • New/changed features are tracked in CHANGELOG.rst.
  • The CI workflow is passing.

`binwidth` was read from the 9th positional argument (like `every`)
although it must be read from the 10th positional argument.
@github-actions github-actions bot added bugfix Pull requests that fix a bug patch Change that results in a new patch version labels Nov 4, 2022
@andthum andthum merged commit 0ff105a into main Nov 4, 2022
@andthum andthum deleted the fix/analysis/mdt/subvolume_charge branch November 4, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull requests that fix a bug patch Change that results in a new patch version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant