Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset button, loading save game tiles are not drawn #16

Closed
catskull opened this issue Jul 15, 2016 · 8 comments
Closed

Reset button, loading save game tiles are not drawn #16

catskull opened this issue Jul 15, 2016 · 8 comments

Comments

@catskull
Copy link

I'm using a real Genesis with an everdrive. If I hit the reset button and load my save game, most tiles are not drawn. If I power off then back on, it works fine.

@catskull
Copy link
Author

Update: after loading, I let it sit for about 10 minutes while I filled out this issue. Eventually the music stopped, then an address error screen showed up and the game crashed. I can attach an image if you'd like!

@andwn andwn closed this as completed in e8f2ea8 Jul 15, 2016
@andwn
Copy link
Owner

andwn commented Jul 15, 2016

Looking good

Screen

Turns out SGDK doesn't clear memory on reset by default. I may have fixed it try this

@andwn
Copy link
Owner

andwn commented Jul 15, 2016

Github automatically closing things again..

@andwn andwn reopened this Jul 15, 2016
@catskull
Copy link
Author

Thanks, I'll try it asap.

@sikthehedgehog
Copy link

Note that problems with the Reset button usually also expose problems when the game ends and returns back to the title screen (where again the program returns back to the beginning but without reinitializing everything). May want to look into that as well.

@andwn
Copy link
Owner

andwn commented Jul 15, 2016

It does crash if you return to the title screen and try to start the game again a couple times. I think I just need to add cleanup code to the end of game_main() because it is no doubt leaking or keeping values lingering at nonzero.

@catskull
Copy link
Author

This is fixed in the latest release.

@andwn
Copy link
Owner

andwn commented Jul 17, 2016

Good to know. I think the game will still crash returning to the title screen (like after you die and say No) so I'll piggyback the fix for that into this issue before closing.

@andwn andwn closed this as completed in c39d4eb Aug 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants