-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
회원 가입 - 텍스트 입력에 대한 버튼의 반응형 프로그래밍 구현 #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c588fd7
to
78935b5
Compare
andy-archive
commented
Nov 15, 2023
Comment on lines
20
to
31
struct Output { | ||
let isTextValid: BehaviorRelay<Bool> | ||
let isTextValid: Observable<Bool> | ||
} | ||
|
||
private let disposeBag = DisposeBag() | ||
|
||
func transform(input: Input) -> Output { | ||
|
||
let isValid = BehaviorRelay(value: false) | ||
|
||
input | ||
let isValid = input | ||
.text | ||
.throttle(.seconds(1), scheduler: MainScheduler.instance) | ||
.map { $0.contains("@") && $0.contains(".") && $0.count >= 6 && $0.count < 50 } | ||
.bind(to: isValid) | ||
.disposed(by: disposeBag) | ||
|
||
return Output(isTextValid: isValid) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BehaviorRelay를 이용해 다시 이를 bind 하는 것이, 단순한 텍스트 입력의 유효성 검사에서는 과분한 것 같아서 Observable로 리팩토링 하였습니다.
This was referenced Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🔗 관련 이슈 or PR
Issues
Pull Requests
✅ 체크리스트
✍️ 작업 내용
📱 구현 화면
🔥 특이 사항
블로그 정리
📚 참고 자료